Repository navigation
Document javaWebWriteStdin - #11
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
This PR documents the javaWebWriteStdin function in docs/browser.md and adds a guard check in src/browser/api.ts to throw a clear error when called before cheerpjInit(). The guard follows the same pattern used by cheerpOSAddStringFile and cheerpOSRemoveStringFile.
review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve
javaWebWriteStdin(text | null)lets a page feedSystem.in, but docs/browser.md never mentioned it. This adds it next to the other page calls: reads wait for text, text sent early is queued,nullends the input, and nothing is echoed.Called before
cheerpjInit, it failed with a TypeError on the missing worker. It now throws "call cheerpjInit() first", ascheerpOSRemoveStringFiledoes.Verified:
pnpm typecheck. There is no browser test harness in the repo; the queueing described is whatworker.tsdoes (stdinqueue andstdinWaiter).