Skip to content

Document javaWebWriteStdin - #11

Merged
Project516 merged 1 commit into
masterfrom
p516/stdin-docs
Nov 1, 2026
Merged

Project516 merged 1 commit into
masterfrom
p516/stdin-docs

Conversation

@Project516

Copy link
Copy Markdown
Owner

javaWebWriteStdin(text | null) lets a page feed System.in, but docs/browser.md never mentioned it. This adds it next to the other page calls: reads wait for text, text sent early is queued, null ends the input, and nothing is echoed.

Called before cheerpjInit, it failed with a TypeError on the missing worker. It now throws "call cheerpjInit() first", as cheerpOSRemoveStringFile does.

Verified: pnpm typecheck. There is no browser test harness in the repo; the queueing described is what worker.ts does (stdin queue and stdinWaiter).

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5527f29e-01d2-4515-816f-3084523386fa
Commits

Reviewing files that changed from the base of the PR and between 1880f4e and 6b7c1b1.

Files selected for processing: 2
  • docs/browser.md
  • src/browser/api.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@project516-review-bot project516-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR documents the javaWebWriteStdin function in docs/browser.md and adds a guard check in src/browser/api.ts to throw a clear error when called before cheerpjInit(). The guard follows the same pattern used by cheerpOSAddStringFile and cheerpOSRemoveStringFile.


review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve

@Project516
Project516 merged commit a42347f into master Nov 1, 2026
6 checks passed
@Project516
Project516 deleted the p516/stdin-docs branch November 1, 2026 21:52
@Project516 Project516 mentioned this pull request Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant