Skip to content

FOUR-34480: Reject unsupported Vocabulary assets during import - #9184

Open
eiresendez wants to merge 1 commit into
developfrom
bugfix/FOUR-34480
Open

eiresendez wants to merge 1 commit into
developfrom
bugfix/FOUR-34480

Conversation

@eiresendez

@eiresendez eiresendez commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Importing the process package attached to FOUR-34480, which contains deprecated Vocabulary assets, can expose database exceptions when the required tables are absent or silently skip assets when their classes are unavailable.

Solution

  • Validate unsupported resources and dependencies before resolving models or processing the import.
  • Centralize compatibility rules for exact classes and namespace prefixes, initially covering Vocabulary.
  • Return an actionable validation message through HTTP and queued imports without exposing internal exceptions or silently discarding dependencies.

How to Test

  1. Import the original process package attached to FOUR-34480. Validation must reject it with a message identifying Vocabulary and explaining how to correct the source process.
  2. Confirm that no process or screen assets are created and another import can be attempted afterward.
  3. Confirm that allowed class names with similar prefixes are not rejected by compatibility validation.

Tests: ImportUnsupportedVocabularyTest passed (15 tests, 33 assertions), covering configurable rules, dependency references, namespace boundaries, HTTP responses, and queue lock behavior. The original ticket attachment also passed the smoke test: validation rejected the package with a clear message and created no process or screen assets.

Related Tickets & Packages

ci:deploy

@cursor

cursor Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes core import/manifest bootstrap and can block packages that previously failed silently; rules are config-driven but wrong prefixes could reject valid exports.

Overview
Import now rejects process packages that reference retired asset types (starting with Vocabulary) before models or exporters are resolved, instead of failing later or silently skipping missing classes.

A configurable unsupported_assets ruleset (import-export.php) matches exact class names and namespace prefixes on assets and dependents. Matches raise UnsupportedImportAssetException, which returns a 422 JSON body with a single actionable message (no stack trace). Queued ImportV2 jobs catch the same case, log that message, skip preview/import, and exit without leaving a manifest or holding the import lock.

Unit tests cover Vocabulary and generic rules, HTTP rendering, and queue lock behavior.

Reviewed by Cursor Bugbot for commit ab57dcb. Bugbot is set up for automated code reviews on this repo. Configure here.

@eiresendez eiresendez self-assigned this Nov 19, 2026
@nolanpro

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://tenant-1.ci-f333d1cb0a.engk8s.processmaker.net

@decisions-sonarqube

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants