Skip to content

Task/FOUR-34428: Move created vue components to plugin project - #9183

Merged
agustinbusso merged 3 commits into
feature/FOUR-34328from
task/FOUR-34428
Nov 20, 2026
Merged

agustinbusso merged 3 commits into
feature/FOUR-34328from
task/FOUR-34428

Conversation

@agustinbusso

@agustinbusso agustinbusso commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Description

Include preview presets in screen YAML exports and normalize imported preset data so JSON strings and YAML mappings persist consistently. Add coverage for deploy, update, and pull workflows.

Related Tickets and PRs

https://processmaker.atlassian.net/browse/FOUR-34428

Include preview presets in screen YAML exports and normalize imported preset data so JSON strings and YAML mappings persist consistently. Add coverage for deploy, update, and pull workflows.
@cursor

cursor Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Deploy/import logic for screen presets changes persisted screen data shape; the CollectionCatalog change silently swallows one MySQL error class when counting records.

Overview
Screen deploy YAML now includes preview_presets on export and applies them on import. Imported presets are normalized so each entry has a string title and JSON string data, with empty YAML mappings coerced to {} instead of [] (including nested keys).

Collection MCP catalog tolerates MySQL error 1412 when counting records on dynamic collection_* tables after in-transaction DDL, so summaries still return with record_count 0 instead of failing.

Tests: New deploy-screen coverage for preset create/update/pull and empty-map encoding; deploy-script test prefers the seeded php-nayra executor; script duplicate test sends required fields and create-scripts permission. Removed DuplicateProcessRequestTest console feature tests.

Reviewed by Cursor Bugbot for commit 454eea0. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor
cursor Bot requested a review from gproly November 19, 2026 12:40
Convert empty arrays to objects before JSON encoding preset data so empty YAML mappings persist as . Add coverage for top-level and nested mappings.
Ignore MySQL error 1412 when reading collection counts while allowing other query errors to propagate. Stabilize script executor and duplication tests, and remove the duplicate process request test.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 454eea0. Configure here.

// MySQL 1412: DDL that created collection_* inside an open txn invalidates the table cache.
if (!str_contains($e->getMessage(), '1412')) {
throw $e;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception matcher swallows unrelated errors

Low Severity

The 1412 guard uses str_contains on the exception message, and Laravel embeds the SQL (including collection_{id}) in that message. Any QueryException for a collection whose id contains 1412 is treated as the DDL cache issue, so record_count stays 0 and real failures are hidden.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 454eea0. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

@agustinbusso
agustinbusso merged commit d7a7553 into feature/FOUR-34328 Nov 20, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants