Skip to content

FOUR-34379 Prevent process import from changing script executor type - #9182

Open
nolanpro wants to merge 2 commits into
developfrom
bugfix/FOUR-34379
Open

nolanpro wants to merge 2 commits into
developfrom
bugfix/FOUR-34379

Conversation

@nolanpro

@nolanpro nolanpro commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

https://processmaker.atlassian.net/browse/FOUR-34379

Importing a process package that includes a script executor could overwrite type on a matched Base executor and flip it to Custom, which then made script runs hit the microservice custom endpoint and 404. Skip type on import update mode, and keep applying it when creating a new executor.

ci:deploy

ci:skip-build

Importing a package that includes a default executor could flip Base to Custom via force-update, which broke microservice script runs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Targets import/update and script runner dispatch paths, but the behavior is narrowly scoped to type with regression tests.

Reviewed by Cursor Bugbot for commit 55ec8f4. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d3d914c. Configure here.

Comment thread ProcessMaker/ImportExport/Manifest.php Resolved
@cursor
cursor Bot requested review from caleeli and gusys November 19, 2026 01:44
@nolanpro

Copy link
Copy Markdown
Contributor Author

QA server K8S was successfully deployed https://tenant-1.ci-c917fde3ab.engk8s.processmaker.net

@nolanpro
nolanpro requested a review from eiresendez November 19, 2026 14:25
Comment thread ProcessMaker/ImportExport/Manifest.php Resolved
@eiresendez
eiresendez self-requested a review November 19, 2026 17:38

@eiresendez eiresendez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@nolanpro

Copy link
Copy Markdown
Contributor Author

QA server K8S was successfully deployed https://tenant-1.ci-c917fde3ab.engk8s.processmaker.net

2 similar comments
@nolanpro

Copy link
Copy Markdown
Contributor Author

QA server K8S was successfully deployed https://tenant-1.ci-c917fde3ab.engk8s.processmaker.net

@nolanpro

Copy link
Copy Markdown
Contributor Author

QA server K8S was successfully deployed https://tenant-1.ci-c917fde3ab.engk8s.processmaker.net

@decisions-sonarqube

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants