Skip to content

Task/FOUR-34427: Create skill to optimize process and create an Alternative "B" of the process - #9177

Merged
agustinbusso merged 6 commits into
feature/FOUR-34328from
task/FOUR-34427
Nov 18, 2026
Merged

agustinbusso merged 6 commits into
feature/FOUR-34328from
task/FOUR-34427

Conversation

@agustinbusso

@agustinbusso agustinbusso commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Introduce an end-to-end refactoring guide with delivery-mode approval, proposal and data-integrity gates, and coordinated asset updates. Link it from PM4 guidance and update skill-routing evaluations.

https://processmaker.atlassian.net/browse/FOUR-34427

Add a tool to enable Alternative B and support selecting A or B when retrieving, validating, and updating process BPMN drafts.
@cursor

cursor Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes core MCP process read/update/validate behavior around drafts, live BPMN, and permissions; regressions could publish or leak unpublished definitions or mishandle Alternative B when the AB package is absent.

Overview
MCP process tools now support A/B process lines when package-ab-testing is installed: a new enable-process-alternative-b tool (and create_alternative_b on update-process) clones Alternative A into B, and get-process / update-process / validate-process accept an alternative of A or B. Responses include alternative and alternatives metadata (b_enabled, package_installed).

update-process no longer writes BPMN straight onto the live process row. BPMN changes hydrate the chosen alternative and call saveDraft, while name/description/status/category use a new persistLiveMetadata path so metadata-only edits do not publish draft XML or wipe unpublished drafts. Editors see draft/alternative BPMN; view-processes users only get published BPMN and cannot validate hidden drafts.

Process server instructions and JSON schemas were extended accordingly; feature tests cover metadata-only updates, combined BPMN+metadata, permission gating, and the Alternative B enable/edit flow.

Reviewed by Cursor Bugbot for commit 29f6f72. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@cursor
cursor Bot requested review from devmiguelangel and gproly November 17, 2026 20:39
Hydrate draft versions only when updating BPMN, and persist accompanying metadata without overwriting the published process definition. Add regression tests for metadata-only and combined updates.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Persist live metadata without triggering versioning behavior that deletes unpublished drafts, and hide draft or Alt B BPMN from users without edit permission. Add regression tests for draft preservation, category updates, and BPMN visibility.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 004190e. Configure here.

Keep view-only users on published BPMN when retrieving or validating processes, and avoid labeling alternative A's XML as B. Preserve updater attribution and clear the project-asset cache when persisting metadata.
@decisions-sonarqube

Copy link
Copy Markdown

@agustinbusso
agustinbusso merged commit fbb9465 into feature/FOUR-34328 Nov 18, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants