Skip to content
Navigation Menu
Sign in
Products
Platform
GitHub
Repository hosting, code review, and collaboration
Copilot
AI coding agent for tasks, projects, and automated work
Build & Ship
Actions
CI/CD and automation
Code Quality
Quality analysis, fixes, and enforcement
Codespaces
Cloud development environments
Secure
Code Security
Vulnerability detection and remediation
Secret Protection
Secret scanning and leak prevention
All Features
Developers
Learn
Documentation
Training
Certifications
Build
Build with Copilot
Customize Copilot
Integrations
Explore
Trending repos
GitHub Sponsors
Developer articles
Changelog
Changelog
Your source for the latest features, improvements, and fixes across GitHub products, all in one place.
Businesses
By Stage
Enterprises
Team
Startups
Nonprofits
By Industry
Healthcare
Financial services
Manufacturing
Government
See all industries
Evaluate GitHub
Why GitHub
Customer Stories
Business insights
Trust Center
Add-ons
GitHub Advanced Security
Enterprise-grade code security
Copilot for business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Resources
Learn & Connect
Documentation
Resource center
Blog
Events & webinars
Community Forum
Customer Stories
Integrations
Support
Customer support
Training
GitHub Status
Company
About
Partners
Changelog
GitHub Universe
GitHub Universe
The event for developers, by developers — talks, workshops, and what’s next for GitHub.
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
PolyMathOrg
PolyMath
Repository navigation
Code
Issues
58
(58)
Pull requests
Discussions
Actions
Projects
Wiki
Security and quality
Insights
More
items
[Issue 154] Refactor PMAccuracy testDataTree method
- #163
#163
Merged
SergeStinckwich
merged 13 commits into
master
PolyMathOrg/PolyMath:master
from
issue-154-refactor-tests
PolyMathOrg/PolyMath:issue-154-refactor-tests
Copy head branch name to clipboard
Jan 10, 2020
Conversation
Commits
13
(13)
Checks
Files changed
Merged
[Issue 154] Refactor PMAccuracy testDataTree method
#163
SergeStinckwich
merged 13 commits into
master
PolyMathOrg/PolyMath:master
from
issue-154-refactor-tests
PolyMathOrg/PolyMath:issue-154-refactor-tests
Copy head branch name to clipboard
Commits
Commits on Dec 27, 2019
[issue-154] Moved the test method to its own test case class so that we can break up the long test method and understand the message better.
hemalvarambhia
committed
2ad957b
View commit details
Copy full SHA for 2ad957b
Browse repository at this point
[issue-154] Moved some test code to an intention-revealing test method & identified a possible smell.
hemalvarambhia
committed
2f4a609
View commit details
Copy full SHA for 2f4a609
Browse repository at this point
[issue-154] Moved a block of code to its own intention-revealing test method.
hemalvarambhia
committed
4faff3d
View commit details
Copy full SHA for 4faff3d
Browse repository at this point
[issue-154] Moved some test code to its own intention-revealing method.
hemalvarambhia
committed
a0e214c
View commit details
Copy full SHA for a0e214c
Browse repository at this point
[issue-154] Added a smell comment to help the next developer.
hemalvarambhia
committed
b9d25e7
View commit details
Copy full SHA for b9d25e7
Browse repository at this point
[issue-154] Added more smells to the smell comment.
hemalvarambhia
committed
3d6b2de
View commit details
Copy full SHA for 3d6b2de
Browse repository at this point
[issue-154] Moved the test code to an intention-revealing test method, extracted the expected result to a role-revealing local variable.
hemalvarambhia
committed
4b7b5e2
View commit details
Copy full SHA for 4b7b5e2
Browse repository at this point
[issue-154] Extracted test code to its own intention-revealing test method, with a comment identifying a coincidence between expected outcome and a default I discovered in the initialize method.
hemalvarambhia
committed
666afa0
View commit details
Copy full SHA for 666afa0
Browse repository at this point
Commits on Dec 28, 2019
[issue-154] Added calls to the super class methods as required.
hemalvarambhia
committed
23ab70b
View commit details
Copy full SHA for 23ab70b
Browse repository at this point
[issue-154] Put the call to the super class method in the right place.
hemalvarambhia
committed
767ec74
View commit details
Copy full SHA for 767ec74
Browse repository at this point
[issue-154] Improved the name of the local variable. We still don't know the role it plays in the test yet so gave it a structural name.
hemalvarambhia
committed
51d5e6c
View commit details
Copy full SHA for 51d5e6c
Browse repository at this point
[issue-154] Improved the name of a local variable.
hemalvarambhia
committed
11b1b53
View commit details
Copy full SHA for 11b1b53
Browse repository at this point
[issue-154] Moved the test code to its own better named test method.
hemalvarambhia
committed
a4b6eb5
View commit details
Copy full SHA for a4b6eb5
Browse repository at this point
You can’t perform that action at this time.