Skip to content

Remove Magic From 'initialize' Methods #152

Closed

Description

@hemalvarambhia

Whilst spiking on how to get the Accuracy-Core package test coverage managed by coveralls, I found that some reflection magic was causing tests (in this testArgumentAt) to fail on travis. This is because findKey was being used out of context, meaning a blank string was returned and the value returned was that mapped to 'AllTheRest' rather than 'Aaa'

To resolve this, we should be more explicit and move details further up the call stack (closer to the client code, away from the server).

Activity

  1. added this to the v1.0.2 milestone on Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions