Skip to content

Some tests methods fail randomly #104

Closed

Description

@SergeStinckwich

Some tests methods like :

  • PMKolmogorovSmirnov1SampleTest >> testRejectOfEqualityHypothesesForSampleVersusDistribution
  • PMBinomialGeneratorTest >> testBinomialGeneratorConvergesToMean
    fail randomly from time to time.

They should be rewritten in a better way.
Maybe we should control the seed in order to have reproducible test.

Activity

  1. changed the title [-]PMKolmogorovSmirnov1SampleTest >> testRejectOfEqualityHypothesesForSampleVersusDistribution fails sometimes[/-] [+]Some tests methods fail randomly[/+] on Apr 30, 2019
  2. added this to the 1.0 milestone on Apr 30, 2019
  3. hemalvarambhia commented on Apr 30, 2019

    @hemalvarambhia
    Contributor

    This is a duplicate of #70, so I'll close that and this will be the new milestone issue.

  4. hemalvarambhia commented on Apr 30, 2019

    @hemalvarambhia
    Contributor

    Can we do just Random seed: 0? To be honest this is a weak area for me in terms of testing.

  5. hemalvarambhia commented on May 11, 2019

    @hemalvarambhia
    Contributor

    @SergeStinckwich In the case of the K-S test work in PR #111 one observation I made is that the one talks about about retaining or rejecting the null hypothesis, whereas the message rejectEqualityHypothesisWithAlpha doesn't use that language. This is also the case in wikipedia. So I was going to propose that we deprecate that in favour of retainNullHypothesisWithin: in a future version. What are your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions