Skip to content

DataFrame and DataSeries should not perform type checks #61

Closed

Description

@olekscode

The current version of DataFrame knows the type of data stored in each of its columns at all times. Every time something is changed (a value is added, removed, or updated), DataFrame checks all types again to keep them up to date. This takes a lot of time.

Same happens with DataSeries.

I think that type checks should not be done in Pharo. Instead of checking if a column contains numbers, we should expect it to behave as if it contains numbers and throw exception otherwise.

Therefore, DataFrame>>columnTypes, DataSeries>>type, and all the related functionality should be removed.

Activity

  1. added this to the v2.0 milestone on Mar 8, 2019
  2. self-assigned this
    on Mar 8, 2019
  3. added a commit that references this issue on Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions