Repository navigation
(BETA) Fix secondary effect skills being added as supports - #6392
Merged
LocalIdentity merged 2 commits intoAug 23, 2023
Merged
LocalIdentity merged 2 commits into
LocalIdentity merged 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6385
Description of the problem being solved:
The ExtraSupport mod parser logic always added an extra mod for the secondary effect which was not always there. If the secondary effect was a skill not a support as is in the case of Doom Blast the skill would be added to the list of supports which prevents it from appearing in the skills drop down.