Skip to content

Fix IgnitePotentialOverride not overriding ignite uptime - #6384

Closed
Aryk-st wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
Aryk-st:feature/POB-6366-ignitepotentialoverride-doesnot-override-ignite-uptime
Closed

Aryk-st wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
Aryk-st:feature/POB-6366-ignitepotentialoverride-doesnot-override-ignite-uptime

Conversation

@Aryk-st

@Aryk-st Aryk-st commented Aug 17, 2023

Copy link
Copy Markdown

Fixes #6366 .

Description of the problem being solved:

Case from the issue:
If you want to override IgnitePotential (whichi is explained as "Stack Potential equates to the number of times you are able to inflict an Ignite on an enemy before the duration of your first Ignite expires") it does override for calculating average damage of ignite, but does nothing in the resulting calculation of DPS because ignite stacks gets recalculating without it just before:

image

So in the case when you're refreshing ignite with say "defiled forces" node, and you override IgnitePotential assuming that you hit faster than ignite duration, DPS calculation does not reflect that

What was done

  • Removed duplicate calculation of igniteStacks:

image

As it was already calculated here earlier:

image

Just added clamping the value with maxStacks

  • Added a tooltip to reflect that IgniteDPS calculation actually includes ignite uptime. Open to formating and naming tips here

-- Also not sure what skillData.triggeredOnDeath condition for. Let me know if it needs more handling

Steps taken to verify a working solution:

  • Used test pob from the issue. Checked values with calculator of what should be

Before screenshot:

image

After screenshot:

image

And with no override:
image

local effectMod = calcLib.mod(skillModList, dotCfg, "AilmentEffect")
igniteStacks = 1
if not skillData.triggeredOnDeath then
igniteStacks = m_min(maxStacks, (output.HitChance / 100) * globalOutput.IgniteDuration / (globalOutput.HitTime or output.Time))

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add output.HitChance to the calculation of stacks earlier? Will also get reflected on weighted average damage

@Aryk-st

Aryk-st commented Aug 17, 2023 •

Copy link
Copy Markdown
Author

Also at 4128 calculation is as follows

igniteStacks = (globalOutput.IgniteDuration / m_max(output.Cooldown, (output.HitTime or output.Time)) * skillData.dpsMultiplier) / maxStacks

And i'm not sure about division by maxStacks for stackPotential.

If our maxStacks is 2
and we do 50 stacks, we should not consider 2 top rolls to be of 2 separate buckets of 25 instances, we should cherry pick 2 top rolls of all 50 stacks, so something like

- (maxStacks - 1)

should be more appropriate?

@LocalIdentity

Copy link
Copy Markdown
Contributor

I've been working over the past day or so fixing this issue along with a couple of others
Superseded by #6386

@Aryk-st
Aryk-st deleted the feature/POB-6366-ignitepotentialoverride-doesnot-override-ignite-uptime branch August 17, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignite acting incorrectly with less 1 stack potential

2 participants