Repository navigation
Conversation
…about ignite uptime calculations
| local effectMod = calcLib.mod(skillModList, dotCfg, "AilmentEffect") | ||
| igniteStacks = 1 | ||
| if not skillData.triggeredOnDeath then | ||
| igniteStacks = m_min(maxStacks, (output.HitChance / 100) * globalOutput.IgniteDuration / (globalOutput.HitTime or output.Time)) |
There was a problem hiding this comment.
Should probably add output.HitChance to the calculation of stacks earlier? Will also get reflected on weighted average damage
|
Also at 4128 calculation is as follows
And i'm not sure about division by maxStacks for stackPotential. If our maxStacks is 2
should be more appropriate? |
|
I've been working over the past day or so fixing this issue along with a couple of others |
Fixes #6366 .
Description of the problem being solved:
Case from the issue:
If you want to override IgnitePotential (whichi is explained as "Stack Potential equates to the number of times you are able to inflict an Ignite on an enemy before the duration of your first Ignite expires") it does override for calculating average damage of ignite, but does nothing in the resulting calculation of DPS because ignite stacks gets recalculating without it just before:
So in the case when you're refreshing ignite with say "defiled forces" node, and you override IgnitePotential assuming that you hit faster than ignite duration, DPS calculation does not reflect that
What was done
As it was already calculated here earlier:
Just added clamping the value with maxStacks
-- Also not sure what skillData.triggeredOnDeath condition for. Let me know if it needs more handling
Steps taken to verify a working solution:
Before screenshot:
After screenshot:
And with no override:
