Skip to content

Fix Sniper's Mark not showing in the Effective DPS Mod breakdown - #10510

Open
lucaskarsten wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
lucaskarsten:fix/3426-taken-from-source-breakdown
Open

lucaskarsten wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
lucaskarsten:fix/3426-taken-from-source-breakdown

Conversation

@lucaskarsten

Copy link
Copy Markdown
Contributor

Fixes #3426

Description of the problem being solved:

The hit damage multiplier in CalcOffence adds three enemy "damage taken" mods only when the skill has the matching flags:

  • ProjectileDamageTaken (Sniper's Mark) for projectile skills
  • ProjectileAttackDamageTaken (Ensnaring Arrow) for projectile attacks
  • TrapMineDamageTaken (Bear Trap) for trap or mine skills

The "Enemy modifiers" lists of the Effective DPS Mod breakdown (physicalHitTaken ... chaosHitTaken in CalcSections) never included those mod names, so the multiplier was right but its source did not show up when hovering it, unlike curses.

The fix adds the three rows to every hit EffMult cell (skill, main hand and off hand, 5 damage types), gated by the same skill flags as the calculation and without a skill cfg, since the calculation sums them unfiltered. CalcsTab:CheckFlag gains anyFlagList so the trap/mine row shows for either flag. Rows with no matching mods are already skipped by the breakdown, so builds without these sources see no change.

Steps taken to verify a working solution:

  • Added spec/System/TestCalcSections_spec.lua: every hit EffMult cell lists the three rows with the right flags; Fireball + Sniper's Mark lists "Sniper's Mark" in the Fire Effective DPS Mod breakdown, Arc + Sniper's Mark does not; anyFlagList passes for trap or mine only. On dev all 3 fail; they pass on this branch.
  • Full busted suite: 748 successes, 0 failures.
  • --tags=builds (the saved 3.13 builds): the same 900 failures, with identical messages, on dev and on this branch, so no saved-build output changed.

Link to a build that showcases this PR:

The issue's repro: Fireball with Sniper's Mark in another socket group, hover Fire in Effective DPS Mod on the Calcs tab.

Before screenshot:

Enemy modifiers: +50 base FireResist only.

After screenshot:

Enemy modifiers: +50 base FireResist and 29% increased ProjectileDamageTaken from Sniper's Mark. With Arc instead of Fireball, the row is not shown.

The hit damage multiplier adds ProjectileDamageTaken (Sniper's Mark),
ProjectileAttackDamageTaken (Ensnaring Arrow) and TrapMineDamageTaken
(Bear Trap) when the skill has the matching flags, but the Enemy
modifiers lists in the Effective DPS Mod breakdown never included those
mod names, so the bonus was applied without showing its source.

Add the three rows to every hit EffMult cell, gated by the same skill
flags as the calculation. CheckFlag gains anyFlagList so the trap/mine
row shows for either flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sniper's Mark Don't Show Up on Effective DPS Mod Breakdown

1 participant