Repository navigation
Fix Sniper's Mark not showing in the Effective DPS Mod breakdown - #10510
Open
lucaskarsten wants to merge 1 commit into
Open
lucaskarsten wants to merge 1 commit into
lucaskarsten wants to merge 1 commit into
Conversation
The hit damage multiplier adds ProjectileDamageTaken (Sniper's Mark), ProjectileAttackDamageTaken (Ensnaring Arrow) and TrapMineDamageTaken (Bear Trap) when the skill has the matching flags, but the Enemy modifiers lists in the Effective DPS Mod breakdown never included those mod names, so the bonus was applied without showing its source. Add the three rows to every hit EffMult cell, gated by the same skill flags as the calculation. CheckFlag gains anyFlagList so the trap/mine row shows for either flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3426
Description of the problem being solved:
The hit damage multiplier in
CalcOffenceadds three enemy "damage taken" mods only when the skill has the matching flags:ProjectileDamageTaken(Sniper's Mark) for projectile skillsProjectileAttackDamageTaken(Ensnaring Arrow) for projectile attacksTrapMineDamageTaken(Bear Trap) for trap or mine skillsThe "Enemy modifiers" lists of the Effective DPS Mod breakdown (
physicalHitTaken...chaosHitTakeninCalcSections) never included those mod names, so the multiplier was right but its source did not show up when hovering it, unlike curses.The fix adds the three rows to every hit EffMult cell (skill, main hand and off hand, 5 damage types), gated by the same skill flags as the calculation and without a skill cfg, since the calculation sums them unfiltered.
CalcsTab:CheckFlaggainsanyFlagListso the trap/mine row shows for either flag. Rows with no matching mods are already skipped by the breakdown, so builds without these sources see no change.Steps taken to verify a working solution:
spec/System/TestCalcSections_spec.lua: every hit EffMult cell lists the three rows with the right flags; Fireball + Sniper's Mark lists "Sniper's Mark" in the Fire Effective DPS Mod breakdown, Arc + Sniper's Mark does not;anyFlagListpasses for trap or mine only. Ondevall 3 fail; they pass on this branch.--tags=builds(the saved 3.13 builds): the same 900 failures, with identical messages, ondevand on this branch, so no saved-build output changed.Link to a build that showcases this PR:
The issue's repro: Fireball with Sniper's Mark in another socket group, hover Fire in Effective DPS Mod on the Calcs tab.
Before screenshot:
Enemy modifiers:
+50 base FireResistonly.After screenshot:
Enemy modifiers:
+50 base FireResistand29% increased ProjectileDamageTakenfrom Sniper's Mark. With Arc instead of Fireball, the row is not shown.