Skip to content

Fix Pact of Lycia uptime consuming an Empowerment per channel stage - #10506

Open
lucaskarsten wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
lucaskarsten:fix/10447-lycia-channelling-uptime
Open

lucaskarsten wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
lucaskarsten:fix/10447-lycia-channelling-uptime

Conversation

@lucaskarsten

Copy link
Copy Markdown
Contributor

Fixes #10447 .

Description of the problem being solved:

Pact of Lycia "Empowers the next 3 Channelling Spells you Cast". Its Heaven's Scourge text says it triggers "while Channelling Empowered Spells" and again "When Channelling Empowered Spells ends", so a channelled spell stays Empowered for the whole channel and one channel uses one Empowerment.

The shared Pact uptime in CalcOffence divides the Empowered count by Speed / Repeats. For a channelled skill Speed is the stage rate, so every stage used up an Empowerment. Lightning Tendrils at 5 stages/s covered 3 / 5 = 0.6 s of the 4.825 s cycle: 12.43% uptime, about 5% more damage instead of 40%.

For Pact of Lycia the use rate is now channels per second, taken from a new config option, "Pact of Lycia channel duration (seconds)". A channel cannot be shorter than one stage, so short durations are clamped to the stage rate (the old value is the floor).

With no duration set the uptime is 100%. This is a modelling choice: the game text has no Empowerment duration, and the usual way to play the gem is to hold the channel through the fight, as the issue describes. Players who release often, or use skills released at the end of a channel (Flameblast, Divine Ire), can enter their channel time. The breakdown then shows the full formula; without a duration it shows "Channelled without releasing".

Not changed: Pact of Ghorr on channelled damage over time spells (e.g. Blight) still uses one Empowerment per stage. Its text ("the next N non-Ailment Damage over Time Spells you Cast") does not mention channelling, so there is no evidence for the same change there.

Steps taken to verify a working solution:

  • Added specs in TestSkills_spec.lua: Lightning Tendrils + Pact of Lycia gives 100% uptime and 1.4x the base TotalDPS with no duration set; with 0.5 s the uptime equals 3 x 0.5 / (cooldown + cast time); with 0.01 s it is clamped to the stage rate.
  • Reverted the fix and confirmed the specs fail (uptime 12.43, expected 100).
  • Issue build: TotalDPS 3255.92 -> 4341.72 (no Pact: 3101.65, so 1.40x). Blight + Lycia 7024.87 -> 9191.42, Scorching Ray + Lycia 4750.69 -> 6334.25. Arc + Lycia, Fireball/Arc + Beidat and Blight + Ghorr are unchanged.
  • busted --lua=luajit in the pathofbuilding-tests image: 747 successes / 0 failures.
  • --tags=builds (the saved 3.13 builds): the same 900 failures, with identical messages, on dev and on this branch, so no saved-build output changed.

Link to a build that showcases this PR:

Build code from the issue.

Before screenshot:

Pact of Lycia uptime 12.43%.

After screenshot:

Pact of Lycia uptime 100% ("Channelled without releasing").

Channelled spells stay Empowered until the channel ends, so each channel uses one Empowerment. Add a config option for the channel duration; without it the channel is assumed to cover the whole uptime.
A channel cannot be shorter than one stage. Show a short breakdown when no channel duration is set, and name the unit in the config label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pact of Lycia 'uptime' makes no sense

1 participant