Skip to content

Board position is not displaying on board-of-directors page for some members #144

Closed

Description

@lovestulip

Issue

There is an issue on the following page: https://opensource.org/about/board-of-directors

The board position "Chair" for Tracy Hinds is not displaying on the page: https://d.pr/i/8bhfZY

I think this issue is coming from here. It appears that the display of the board position (member-position) is currently dependent on the pronouns field. Tracy Hinds does not have that field filled out. See: https://d.pr/i/2co6zO

You can review here: https://opensource.org/wp-admin/post.php?post=2929&action=edit

The condition that checks if the board_position field exists is "nested" inside the check for pronouns.

Strangely, her board position does displayed on her profile page: https://opensource.org/board-member/tracy-hinds

Could there be additional conditions to consider?

Can we please make sure the member position is displayed independently of pronouns?

Please be sure to first do this on staging for our partner to review the changes.

Context

See ZD link on the internal dev request.

Activity

  1. gin0115 commented on Nov 11, 2024

    @gin0115
    Contributor

    Ive tracked it down to here, not sure why but we seem to be setting the max number of posts as

    How posts per page is worked out
    = -1 + ( ({current page number} - 1 ) * 12)
    // Becomes
    = -1 + ( (0 - 1 ) * 12)
    = -1 + -12
    = 11
    

    So even though there are 12 results on the board page, it is only showing 11. Im not sure why this logic exists, i dont want to just change it as i dont know why its even here. This was added in back in 2021 when the site was intially setup.

    What im going to do is add a means to shortcircuit this, so we can ignore this and ensure it always shows all.

  2. smaffulli commented on Nov 11, 2024

    @smaffulli
    Contributor
  3. gin0115 commented on Nov 11, 2024

    @gin0115
    Contributor

    @smaffulli

    Ahh, that makes sense, it seems to be applying to various query loops elsewhere on the site. I will tweak this to only apply to the /blog archive and not any other pages that have query loops in them

    Thanks for that insight @smaffulli :)

  4. gin0115 commented on Nov 12, 2024

    @gin0115
    Contributor

    @smaffulli

    We have deployed this to staging now and it all seems to be working as expected (i added a test board member on staging to show 12)

    I will get this deployed to production today

  5. smaffulli commented on Nov 12, 2024

    @smaffulli
    Contributor
  6. gin0115 commented on Nov 12, 2024

    @gin0115
    Contributor

    The CSS should add a 4% gap on that grid, but it looks like this has been overwritten thanks to the customizer

    @media only screen and (min-width: 600px) {
      .archive-columns {
          /* gap: 4%;*/
      }
    }

    This custom code is not present on the staging site.

    Production
    image

    Staging
    image

    Ive now applied the same custom css rule to staging so they are in sync

  7. smaffulli commented on Nov 12, 2024

    @smaffulli
    Contributor
  8. gin0115 commented on Nov 12, 2024

    @gin0115
    Contributor

    We have deployed this

    // If this is a page and its not set as the page for posts, return.

    Might need to clear out any caches that could be caching that page, but hopefully this resolves the issue

  9. lovestulip commented on Nov 18, 2024

    @lovestulip
    Author

    @gin0115 I'm not seeing the changes applied to this page just yet: https://opensource.org/about/board-of-directors

    Might need to clear out any caches that could be caching that page, but hopefully this resolves the issue

    I purged the edge cache and this issue still persists. Is there another cache that could be an issue?

  10. securityjedi commented on Nov 19, 2024

    @securityjedi

    Monitoring this for the next week. cc: @gin0115

  11. gin0115 commented on Nov 19, 2024

    @gin0115
    Contributor

    I got sidetracked with the missing members, and I glossed over the issue with pronouns and roles being shown.

    This has been patched on staging
    image

    Will get a PR for main setup

  12. securityjedi commented on Nov 21, 2024

    @securityjedi

    This was pushed to production.

  13. lovestulip commented on Nov 25, 2024

    @lovestulip
    Author

    I'll close this one out as this is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions