You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Board position is not displaying on board-of-directors page for some members #144
The board position "Chair" for Tracy Hinds is not displaying on the page: https://d.pr/i/8bhfZY
I think this issue is coming from here. It appears that the display of the board position (member-position) is currently dependent on the pronouns field. Tracy Hinds does not have that field filled out. See: https://d.pr/i/2co6zO
Ive tracked it down to here, not sure why but we seem to be setting the max number of posts as
How posts per page is worked out
= -1 + ( ({current page number} - 1 ) * 12)
// Becomes
= -1 + ( (0 - 1 ) * 12)
= -1 + -12
= 11
So even though there are 12 results on the board page, it is only showing 11. Im not sure why this logic exists, i dont want to just change it as i dont know why its even here. This was added in back in 2021 when the site was intially setup.
What im going to do is add a means to shortcircuit this, so we can ignore this and ensure it always shows all.
If that logic covers the blog posts, I can think that the reason is for the
landing page of the *blog* which shows a featured post up top and the
latest posts below. Maybe that's why?
this issue wasn't visible on the board archive because we used to have 10
board directors and now we have 12.
Ahh, that makes sense, it seems to be applying to various query loops elsewhere on the site. I will tweak this to only apply to the /blog archive and not any other pages that have query loops in them
Hi Glynn, the 12 on staging look alright but I see the directors are on
2-column view while in production we have a better 3-column.
https://opensource.org/about/board-of-directors
did the patch change the arrangement of the archive?
Activity
gin0115 commentedon Nov 11, 2024
Ive tracked it down to here, not sure why but we seem to be setting the max number of posts as
So even though there are 12 results on the board page, it is only showing 11. Im not sure why this logic exists, i dont want to just change it as i dont know why its even here. This was added in back in 2021 when the site was intially setup.
What im going to do is add a means to shortcircuit this, so we can ignore this and ensure it always shows all.
smaffulli commentedon Nov 11, 2024
gin0115 commentedon Nov 11, 2024
@smaffulli
Ahh, that makes sense, it seems to be applying to various query loops elsewhere on the site. I will tweak this to only apply to the
/blogarchive and not any other pages that have query loops in themThanks for that insight @smaffulli :)
gin0115 commentedon Nov 12, 2024
@smaffulli
We have deployed this to staging now and it all seems to be working as expected (i added a test board member on staging to show 12)
I will get this deployed to production today
smaffulli commentedon Nov 12, 2024
gin0115 commentedon Nov 12, 2024
The CSS should add a 4% gap on that grid, but it looks like this has been overwritten thanks to the customizer
This custom code is not present on the staging site.
Production

Staging

Ive now applied the same custom css rule to staging so they are in sync
smaffulli commentedon Nov 12, 2024
gin0115 commentedon Nov 12, 2024
We have deployed this
dotOrg/themes/osi/functions.php
Line 379 in 935953b
Might need to clear out any caches that could be caching that page, but hopefully this resolves the issue
lovestulip commentedon Nov 18, 2024
@gin0115 I'm not seeing the changes applied to this page just yet: https://opensource.org/about/board-of-directors
I purged the edge cache and this issue still persists. Is there another cache that could be an issue?
securityjedi commentedon Nov 19, 2024
Monitoring this for the next week. cc: @gin0115
gin0115 commentedon Nov 19, 2024
I got sidetracked with the missing members, and I glossed over the issue with pronouns and roles being shown.
This has been patched on staging

Will get a PR for main setup
securityjedi commentedon Nov 21, 2024
This was pushed to production.
lovestulip commentedon Nov 25, 2024
I'll close this one out as this is now resolved.