Repository navigation
Issue 6 first login required fields - #68
Merged
jonbartels merged 1 commit intoMay 2, 2025
Merged
jonbartels merged 1 commit into
jonbartels merged 1 commit into
Conversation
jonbartels
force-pushed
the
issue-6-first-login-required-fields
branch
3 times, most recently
from
April 30, 2025 18:59
4eb8c66 to
2691365
Compare
gibson9583
approved these changes
Apr 30, 2025
kpalang
approved these changes
May 1, 2025
tonygermano
requested changes
May 1, 2025
tonygermano
left a comment
tonygermano
left a comment
Member
There was a problem hiding this comment.
I'd like to take a look at rolling back this class to what it looked like in 4.0 before they started making the changes that required all of the additional fields. There may be a few things we need to keep, because I think a few extra fields were added, but I know a lot of GUI elements were added or hidden which we don't need or want. We likely don't need the changes that pre-populate the form with values saved in the local java user profile if we aren't requiring the fields, anymore. I think comparing what is there currently to a known desired state is probably easier than trying to slowly undo things piece by piece and likely overlooking something.
My apologies for not including this in the detail of the issue.
tonygermano
approved these changes
May 1, 2025
tonygermano
left a comment
tonygermano
left a comment
Member
There was a problem hiding this comment.
I'll open a new issue for the rollback.
Signed-off-by: Jon Bartels <jon.bartels@teladochealth.com>
jonbartels
force-pushed
the
issue-6-first-login-required-fields
branch
from
May 2, 2025 18:39
2691365 to
1bd8e95
Compare
jcdlbs
added a commit
to SagaHealthcareIT/open-integration-engine
that referenced
this pull request
Oct 29, 2026
…ap.json From 4.7.0 the engine no longer seeds a new database with admin/admin. It takes server.initialadminpassword from conf/mirth.properties, or else generates a random password and logs it once. For a new install the OpenShare console now generates that password, shows it to the user once, and ships it in the per-server bootstrap.json as engine.initialAdminPassword. The install action that already unpacks the plugin sidecar and copies bootstrap.json now also writes that value into mirth.properties, before the service is installed and started, so the engine's first start creates the database with it. The OpenShare plugin blanks the property again after that start (mirthsync-gateway-plugin OpenIntegrationEngine#68). An existing database ignores it. The install4j runtime has no JSON parser, so the action reads only this one string field; the console generates it from characters that need no escaping in JSON or a .properties value. A value outside the characters a .properties value carries literally is logged and skipped rather than written, so the engine falls back to its own logged random password. The value itself is never logged. The step runs after the bootstrap.json copy, so it can never block registration. Tested: an unsigned Unix installer (install4jc -u -b 42) installed unattended in a Java 21 container with the PR OpenIntegrationEngine#68 plugin as the sidecar. The engine came up as 4.7.0, the console-style password signed in (200), admin/admin was refused (401), the engine logged no random password, and the plugin had blanked the property. The password appeared in neither the install log nor the engine log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6
First login and user edit only require username and password