Repository navigation
Conversation
ConnectServiceUtil, HttpReceiver and MirthWebServer only use the SC_* constants, which httpcore 4 defines with the same values. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
kpalang,
mgaffigan,
pacmano1 and
ssrowe
October 30, 2026 10:43
mgaffigan
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ConnectServiceUtil,HttpReceiverandMirthWebServeruse httpcore 4'sorg.apache.http.HttpStatusinstead of commons-httpclient 3's.Why
This is one step toward dropping commons-httpclient 3.0.1, which has been EOL since 2007.
Reviewer notes
SC_OK,SC_MOVED_TEMPORARILY,SC_NOT_FOUNDandSC_INTERNAL_SERVER_ERRORare used. httpcore defines all four with the same values, and they're compile-time constants.org.apache.httpclasses, so httpcore was already required wherever they run (client, CLI, server)../gradlew :server:compileJava :client:compileJava :command:compileJavaand theHttpReceiver*tests (19).🤖 Generated with Claude Code