Skip to content

Avoid pattern-matching instanceof in DestinationSet #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NicoPiel wants to merge 1 commit into from
Closed

Avoid pattern-matching instanceof in DestinationSet #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/main/java/com/mirth/connect/server/userutil/DestinationSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ public DestinationSet(ImmutableConnectorMessage connectorMessage) {
Set<Integer> metaDataIds = null;

try {
if (connectorMessage.getSourceMap().get(Constants.DESTINATION_SET_KEY) instanceof Set<?> set) {
// No pattern matching here: the client's reference parser only understands Java 5 syntax
Object set = connectorMessage.getSourceMap().get(Constants.DESTINATION_SET_KEY);
if (set instanceof Set) {
destinationIdMap = connectorMessage.getDestinationIdMap();
metaDataIds = (Set<Integer>) set;
}
Expand Down
Loading