You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The recent PR #69 completed the removal of all geospatial capability (even optional ones) around SamplingFeatures.FeatureGeometry that started with a commit in early June that removed the shape method on the models.pySamplingFeatures class and related, geoalchemy-based functionality.
more broadly, I don't agree with the complete removal of all geospatial capability that started in early June commits. I can definitely see the benefit of making that functionality more optional, including moving related import statements into the optional methods that use them (or even into a utilities module) so that packages like shapely and geoalchemy are not required. But that's different from removing all geospatial capability entirely. FYI, I believe Choonhan was relying on the shape function for ODM2RESTAPI, and I personally found it very useful and non-obtrusive, except requiring the installation of those geospatial packages.
TO-DO for me (Emilio):
Start a new 'geospatial' branch to bring back the deleted functionality, and work towards making it as lightweight/optional as possible so it doesn't impose the burden of installing additional packages for user who would never use it.
Develop usage examples for that code.
Think about adding functionality to go from FeatureGeometryWKT to Python geospatial objects.
Look back through old issues to see what relevant, old discussions should be linked up into this issue.
cc'ing @lsetiawan, b/c I plan to start pulling him into odm2api development later this month. He's already built some ODM2 geodjango experience, and has a strong Python geospatial experience.
@emiliom - thanks for capturing this. We really needed to move forward with the API for several reasons and the geospatial stuff was holding us back. We just hadn't been able to figure it out. So, if we can get some help with this and figure out how to add it back in with support across the RDBMS, that would be awesome.
Just for reference: two older issues with relevant discussions are #29 and #14. But specially #29!
Also note my old references to my sfgeometry_em_1 branch from Feb. 2016. That branch no longer exists on the github repo, but I probably still have it around on my local clone.
Just saw this 1-year-old commit to ODM2RESTfulWebServices that's relevant to this topics/issue. I'm adding a link to it here for reference, to follow up once we focus on this topic in odm2api.
Activity
horsburgh commentedon Sep 6, 2016
@emiliom - thanks for capturing this. We really needed to move forward with the API for several reasons and the geospatial stuff was holding us back. We just hadn't been able to figure it out. So, if we can get some help with this and figure out how to add it back in with support across the RDBMS, that would be awesome.
emiliom commentedon Feb 2, 2017
Just for reference: two older issues with relevant discussions are #29 and #14. But specially #29!
Also note my old references to my
sfgeometry_em_1branch from Feb. 2016. That branch no longer exists on the github repo, but I probably still have it around on my local clone.emiliom commentedon Feb 28, 2017
Just saw this 1-year-old commit to ODM2RESTfulWebServices that's relevant to this topics/issue. I'm adding a link to it here for reference, to follow up once we focus on this topic in
odm2api.emiliom commentedon May 25, 2017
Adding a link to PR #72 (removed dependencies to geoalchemy and shapely), which we just merged. It includes some possibly useful comments, PR's, etc.