You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix git histories for module-hierarchy reorganized files #159
The module-hierarchy reorg (completed in release 0.7.1) was tracked in issue #146, that I left open for future reference once we're ready to remove the backwards-compatibility old hierarchy.
This specific issue (preserving git history in the files at the new hierarchy) was discussed in #145 (comment). See the specific steps/approach I had proposed there. We'll need to test that these steps get the job done.
It's looking like this might be a non-issue, ultimately. The challenge apparently is in whether a git log viewing tool (like gitkraken, or github) can detect the link between the old file path and the new file path, specially with git log --follow or its analog. Based on a small test where I took the master branch as of today (4/27/2019), created a new branch from it, then did git rm odm2api/ODM2/models.py, the moved models.py (at odm2api/models.py) does have the complete history available if the viewer tool is smart enough (as is gitkraken) or using git log --follow <file-at-new-path>. I also did another test with ODM2/services/readService.py, and that was "successful" too.
Activity
emiliom commentedon Apr 28, 2019
It's looking like this might be a non-issue, ultimately. The challenge apparently is in whether a
git logviewing tool (like gitkraken, or github) can detect the link between the old file path and the new file path, specially withgit log --followor its analog. Based on a small test where I took themasterbranch as of today (4/27/2019), created a new branch from it, then didgit rm odm2api/ODM2/models.py, the moved models.py (atodm2api/models.py) does have the complete history available if the viewer tool is smart enough (as is gitkraken) or usinggit log --follow <file-at-new-path>. I also did another test with ODM2/services/readService.py, and that was "successful" too.