Repository navigation
Conversation
Capture live policy with the generation claim under shared policy/provider mutation fences. Retain the admitted input for retries and recovery, preserving frozen snapshot precedence. Closes NVIDIA#5109 Depends on corrected PR NVIDIA#4735. BREAKING CHANGE: Complete raw SandboxStatus literals must initialize launch_policy or use generated defaults. Upgrade gateway writers together and qualify the next minor release. Signed-off-by: Shiju <shiju@nvidia.com>
|
Label |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. rust-sdk — No explicit risk acceptance foundSDK-exposed
Review details
Advisory review; publication gates are unchanged. |
Check an explicit resource version against the locked sandbox snapshot before policy deduplication. Preserve zero-version compatibility and lifecycle fencing. The existing concurrent-backfill regression now rejects both stale requests. Refs NVIDIA#5109 Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
feat/5109-generation-launch-policy/shiju-nv
branch
from
November 2, 2026 14:46
e0723be to
23c1149
Compare
shiju-nv
changed the base branch from
main
to
feat/frozen-sandbox-policy/shiju-nv
November 2, 2026 14:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A launch retry or gateway recovery must use the policy admitted for that generation, even if policy changes later. This captures and retains that policy when the generation is claimed. Ordinary sandboxes can take a new static policy after stopping when the driver supports the contract; frozen sandboxes keep their original accepted snapshot.
Related Issue
Closes #5109. Part of #5114.
Depends on corrected frozen-policy PR #4735. Review this layer against
feat/frozen-sandbox-policy/shiju-nv. For the fork-based series, land the parent first, then replay only this layer onto the resultingmain.Changes
StartSandbox.launch_policyat field 10, preserving resume fields 7/8 and the durable sandbox snapshot at field 9.Release Notes
Source-breaking API addition for the next minor release only. Complete raw Rust status literals need
launch_policy: Noneor defaults. Upgrade gateway writers together. If a negotiated launch loses its retained input, stop and explicitly start the sandbox to claim a new generation; retries do not invent replacement input. Maintainers must seed and qualify the minor train before landing; do not merge or backport this into the active patch train.Testing
Checklist