Skip to content

fix(video): validate configured image-only models - #308

Open
Ricardo-M-L wants to merge 1 commit into
MiniMax-AI:mainfrom
Ricardo-M-L:fix/video-default-fast-image-20261114
Open

Ricardo-M-L wants to merge 1 commit into
MiniMax-AI:mainfrom
Ricardo-M-L:fix/video-default-fast-image-20261114

Conversation

@Ricardo-M-L

@Ricardo-M-L Ricardo-M-L commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

With defaultVideoModel set to MiniMax-Hailuo-2.3-Fast, video generate --prompt ... bypassed the existing image-input guard and submitted a text-only request to an image-only model. The same request was correctly rejected when the model came from --model.

Apply the guard to the resolved model, after explicit/configured/default selection. Extend the existing regression to exercise both selection paths.

Validation: the configured-model case fails on unchanged ae29aae and passes with the fix; 47 video command/SDK/V2 tests pass. bun run typecheck, bun run lint, bun run build, and git diff --check pass. Lint retains one existing warning in an untouched speech SDK test. No live generation requests were made.

Prepared and tested with AI assistance (Codex).


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant