Repository navigation
fix(video): validate configured image-only models - #308
Open
Ricardo-M-L wants to merge 1 commit into
Open
Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
defaultVideoModelset toMiniMax-Hailuo-2.3-Fast,video generate --prompt ...bypassed the existing image-input guard and submitted a text-only request to an image-only model. The same request was correctly rejected when the model came from--model.Apply the guard to the resolved model, after explicit/configured/default selection. Extend the existing regression to exercise both selection paths.
Validation: the configured-model case fails on unchanged
ae29aaeand passes with the fix; 47 video command/SDK/V2 tests pass.bun run typecheck,bun run lint,bun run build, andgit diff --checkpass. Lint retains one existing warning in an untouched speech SDK test. No live generation requests were made.Prepared and tested with AI assistance (Codex).
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.