Skip to content

fix(args): accept negative numeric option values - #307

Open
Ricardo-M-L wants to merge 1 commit into
MiniMax-AI:mainfrom
Ricardo-M-L:fix/negative-numeric-options-20261114
Open

Ricardo-M-L wants to merge 1 commit into
MiniMax-AI:mainfrom
Ricardo-M-L:fix/negative-numeric-options-20261114

Conversation

@Ricardo-M-L

@Ricardo-M-L Ricardo-M-L commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

mmx speech synthesize --pitch -2 was rejected as a missing value even though --pitch=-2 worked and the numeric parser accepted negative values. Allow a separate finite negative value for options declared as numbers; keep rejecting option tokens where a value is required and keep string/array option handling unchanged.

Validation: the three new negative-value cases failed on ae29aae and pass with the fix; 41 argument/speech-command tests pass. bun run typecheck, bun run lint, bun run build, and git diff --check pass. Lint reports one existing no-explicit-any warning in an untouched speech SDK test. Tests use offline fixtures; no provider calls were made.

Prepared and tested with AI assistance (Codex).


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant