Repository navigation
fix(args): accept negative numeric option values - #307
Open
Ricardo-M-L wants to merge 1 commit into
Open
Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mmx speech synthesize --pitch -2was rejected as a missing value even though--pitch=-2worked and the numeric parser accepted negative values. Allow a separate finite negative value for options declared as numbers; keep rejecting option tokens where a value is required and keep string/array option handling unchanged.Validation: the three new negative-value cases failed on
ae29aaeand pass with the fix; 41 argument/speech-command tests pass.bun run typecheck,bun run lint,bun run build, andgit diff --checkpass. Lint reports one existingno-explicit-anywarning in an untouched speech SDK test. Tests use offline fixtures; no provider calls were made.Prepared and tested with AI assistance (Codex).
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.