Skip to content

fix(mmx-octopus): cross-session awareness is off by default and really stops collecting (v1.10.0) - #138

Open
antianqi wants to merge 3 commits into
MiniMax-AI:mainfrom
antianqi:fix/marketplace-v1910
Open

antianqi wants to merge 3 commits into
MiniMax-AI:mainfrom
antianqi:fix/marketplace-v1910

Conversation

@antianqi

@antianqi antianqi commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

What the review found

Two problems in this package, both confirmed against the code (not just read off the issue):

  1. petAware defaulted to true. The cross-session feature was on for every new install.
  2. Turning it off did not stop collection. The setting only gated the prompt injection —
    observe({all: true}) and sessions() were still called on every request.
    Collecting-but-not-using is not the same as not collecting.

What changed

  • petAware now defaults to false (miniapp/node/state.mjs).
    setPetAware() only turns it on for an explicit true; undefined counts as off.
  • When it is off, collection really stops (miniapp/node/observe.mjs):
    the observe subscription is aborted, the board polling timer is cleared, and the
    cross-session data already on screen is wiped. The same guard is used in
    scheduleObserve(), scheduleBoard() and restartObserve() — one place, so it cannot drift.
  • The panel now shows the switch as off by default and says so.
  • README.md / README.zh-CN.md disclose what is read, how it is used, that it is
    off by default since 1.10.0, and that the minimum client version is now 3.1.6.
  • Version bumped to 1.10.0 (behaviour change).

Tests

The scenarios live in tests/petaware-scenarios.mjs and are shipped with the package:

node --test tests/petaware-default-off.test.mjs

They start a real server against a mock host and count the actual observe /
sessions() calls — they do not grep the source. They cover the three cases the
review named: first launch, toggling the switch, and restarting.

Two of them are negative injections: they break a copy of the production module
(remove the guard / flip the default back on) and assert that the criterion catches it.
A test that cannot fail proves nothing.

The same implementation backs our own internal self-check, so the two cannot disagree.

Verified

  • The shipped test passes; with the guard removed or the default flipped back on, it
    fails within seconds and names the broken assertions (the scenario runner is a
    child process with a timeout, so a broken build reports a failure instead of hanging CI).
  • Our full internal self-check: 900 checks, 0 failures.
  • The repository's own checks pass (npm test, npm run validate).

…y stops collecting (v1.10.0)

The marketplace review (issue MiniMax-AI#136) found two real problems, and both were ours:

- petAware defaulted to true. A privacy-sensitive cross-session feature has to be
  off by default, so a fresh install now starts with it off and the user turns
  it on themselves.
- Turning it off only stopped the summary from reaching the prompt; the
  collection kept going. observe({all:true}) and sessions() were still called.
  The switch now reaches the collection layer: while it is off the package does
  not subscribe to session events, does not list sessions, and does not put
  anything about other sessions into her prompt. Turning it off at runtime
  aborts the subscription, stops the board timer and clears what the board had
  already shown. A restart keeps it off.

Also: the README said the package needs MiniMax Code 3.1.5; it needs 3.1.6.

Version 1.9.0 -> 1.10.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant