Repository navigation
Bump TidepoolKit so a revoked Tidepool login drops the session - #576
Merged
Merged
Conversation
TidepoolKit kept the session when the token endpoint rejected the refresh token (400 invalid_grant, as after a password change), so TidepoolService never raised its re-login alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves TidepoolKit (
dev, in the workspacePackage.resolved) from 290bd043 to 0f127deb:400 {"error":"invalid_grant"}, for example after a Tidepool password change) or answers 401, TidepoolKit now clears the session and notifies observers. Before, the 400 surfaced asresponseMalformedJSON, the session stayed set, and every later upload failed the same way without telling the user.With LoopKit/TidepoolService#46 (already in next-dev), the dropped session raises the "authentication-needed" alert, the service survives a relaunch with no session, and logging back in retracts the alert. Without this bump,
apiDidUpdateSession(nil)is never called for a revoked login, so #46 never runs in that case. This is the same bug nightscout/Trio#1706 works around on the Trio side.Built with the LoopWorkspace scheme for device with
-disableAutomaticPackageResolution, so the build used TidepoolKit 0f127deb: 19 plugins and the watch app. Tested end to end on a device: after a Tidepool password change, the alert appeared and the service stayed set up; logging back in cleared the alert.