Repository navigation
Run the TidepoolService, EversenseKit, LibreLoop, LoopAlgorithm and RoundWhiteDiscKit tests in CI - #575
Merged
Conversation
…oundWhiteDiscKit tests in CI The LoopWorkspace scheme's test action left out five test targets, so CI never ran them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI runs
xcodebuild teston the LoopWorkspace scheme, whose test action listed 11 test targets. These five weren't among them, so they never ran in CI:Left out on purpose: TidepoolServiceKitUITests (no sources, only an Info.plist) and TrueTime's own test targets. Loop's scheme still lists a
DoseMathTeststarget that no longer exists in the project; that's harmless and not touched here.Also bumps EversenseKit to 03279e6f for LoopKit/EversenseKit#13, which fixes the one EversenseKitTests failure (
PackageTest.currentGlucoseOld, a wrong test, not a parser bug). That bump brings in LoopKit/EversenseKit#9 and #12 too; #574 pins the same commit, so the two merge cleanly in either order.Ran the scheme's full test action locally on an iPhone 17 simulator with the submodules from #574 and the EversenseKit fix: every target passed. LoopTests needed a second run after the simulator failed to launch the host app once.