Repository navigation
Conversation
The certs step ignored the fastlane certs exit status so that the renewal check could nuke and recreate an expired certificate. When the check finds only other, valid Distribution certificates in the team, no renewal runs, the job still succeeded, and the build later failed at signing with the same Match error. Record the certs result and fail the job in that case, pointing to Match's error about the certificate stored in Match-Secrets. Reported in LoopKit/Loop#2661.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the silent certificate failure reported in LoopKit/Loop#2661.
Problem
create_certs.ymlrunsfastlane certs || true, so thatcheck_and_renew_certificatescan nuke and recreate an expired Distribution certificate. When Match rejects the certificate stored in Match-Secrets but the team still has other valid Distribution certificates, the check writesnew_certificate_needed=false. No renewal runs, the Create Certificates job succeeds, and Build & Archive fails later at signing with the same Match error, far from its cause.Change
id: certsand recordscerts_failed=true/falsein$GITHUB_OUTPUT. It still continues on errors without an exit-code annotation.set_outputfails the job with an::error::pointing at the Match error in the certs step when the certs lane failed, no new certificate is needed, andFORCE_NUKE_CERTSis not set.The renewal paths are unchanged.
Testing
The YAML parses. I simulated the
set_outputscript for 5 cases:It has not been run on GitHub Actions against a live Apple account.