Repository navigation
Conversation
Keep the Fastlane Match outcome and fail the certificate job when no renewal path is available. Refs LoopKit/Loop#2661. Prepared and tested with Codex assistance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base
LoopKit/LoopWorkspace:devat1a1c7538fdeb0bbb1171998d0bd0dd15fff91ce8.Issue LoopKit/Loop#2661.
Summary
An expired certificate in
Match-Secretscan fail Fastlane Match while unrelated valid certificates make the team-wide renewal check pass. Keep the original Match step outcome so the certificate job can report the failure before the archive starts.The error points to the original Match output. The change uses GitHub Actions'
outcome, which records the exit status beforecontinue-on-erroris applied. The existing portal-driven and explicitly forced renewal paths keep their current behavior.Evidence
new_certificate_needed: false, the upstream shell step exited 0.Match-Secrets.git diff --checkand actionlint passed. Actionlint 1.7.12 does not recognize the existingxcode-27label, which is listed in GitHub's runner documentation. I excluded that diagnostic only.Merge impact
The change is reversible and limited to the GitHub Actions certificate preflight. It changes no certificate selection or revocation logic.
Codex drafted the workflow change from the observed failure in the linked issue and ran the local checks. The workflow conventions and renewal paths received a separate AI-assisted review.