Repository navigation
Make carb entry limits configurable - #2669
damonbayer wants to merge 3 commits into
Conversation
|
Thanks! Please add a clear description of the use case(s) that are driving this to the PR. Best to hear from those who need this, but you're just devving for others, would be good to hear your understanding of the need too. (Edit: not asking for some formal "use case" pattern to be followed, as sometimes people interpret this ask as, just a clear description of the "why" that's driving this). |
|
@ps2 Update the original description with the following: MotivationThis obviates the need for the Modify Carb Warning & Limit: Low Carb to 49 & 99 and Modify Carb Warning & Limit: High Carb to 201 & 300. Per internal stats, ~3% of Loop users enable one of these changes. If we accept that there should be some guards against carb entries that are too big, it makes sense that this would differ between users. I eat a low-carb diet, so I would probably lower these to 30g/60g. I imagine it might also be beneficial for children, who eat fewer carbs than adults. I also imagine that meals with more carbs than the default guards might be common for some users. |
Motivation
This obviates the need for the Modify Carb Warning & Limit: Low Carb to 49 & 99 and Modify Carb Warning & Limit: High Carb to 201 & 300. Per internal stats, ~3% of Loop users enable one of these changes.
If we accept that there should be some guards against carb entries that are too big, it makes sense that this would differ between users. I eat a low-carb diet, so I would probably lower these to 30g/60g. I imagine it might also be beneficial for children, who eat fewer carbs than adults. I also imagine that meals with more carbs than the default guards might be common for some users.
Summary
Depends on LoopKit/LoopKit#692 for the Therapy Settings card. Related discussion in #494.
Validation
SimpleBolusViewModelTestson an iPhone 18 Pro simulator. The new regression test checks that a 300.5 g maximum accepts 300.5 g and blocks 300.6 g before saving or bolusing.