Repository navigation
Add meal reminders for future carb entries - #2666
Open
damonbayer wants to merge 3 commits into
Open
damonbayer wants to merge 3 commits into
damonbayer wants to merge 3 commits into
Conversation
damonbayer
force-pushed
the
dmb/meal-reminder-toggle
branch
from
November 7, 2026 23:59
98d46aa to
594ccd7
Compare
Contributor
Author
|
I had an agent implement this mostly to evaluate / mock up the user experience. I have no idea if the technical details about managing the reminders are appropriate. |
damonbayer
marked this pull request as ready for review
November 8, 2026 05:55
This was referenced Nov 8, 2026
Contributor
Test✅ successful test
ConfigurationStart with LoopWorkspace next-dev commit
Test Details
The reminder row is always present, but timer can only be enabled for carbs in the future. |
Contributor
Code ReviewI picked up a few comments from a Claude review:
Passing this one on for @damonbayer to decide if it's a concern:
|
Contributor
Author
@marionbarker Do you think it should be more prominent? I think most of the time you are eating, you would not want a loud notification to come from your phone. Especially if you were already eating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When someone logs carbs for a future meal and boluses in advance, it can be easy to lose track of when they planned to eat. This adds an opt-in ⏰ Remind Me switch to each carb entry so they can request a reminder for that meal.
Addresses #2650. Zulip design discussion.
Screenshots
Carb entry on an iPhone 18 Pro simulator (iOS 27.2) with a 45 g demo meal.
Future entry with the reminder switched on
Validation