Skip to content

Modify maxCarbEntryFutureTime to 4 hours - #2125

Closed
marionbarker wants to merge 1 commit into
LoopKit:devfrom
marionbarker:future_carbs
Closed

marionbarker wants to merge 1 commit into
LoopKit:devfrom
marionbarker:future_carbs

Conversation

@marionbarker

Copy link
Copy Markdown
Contributor

Many people use future carb entry to handle fat and protein rise.
I believe increasing this value from 1 hour to 4 hours is a reasonable compromise between safety and convenience.

Note:

  • This is a personal opinion
  • I use 4 hours when dosing for my evening meal
    • I enter a prompt meal entry and future fat/protein rise entry at the same time
    • I am able to do this because I customized my code

@ksilive

ksilive commented Feb 16, 2024

Copy link
Copy Markdown

Hi, im against this change as its more easy to forget (and maybe make a mistake as a novice user) and can lead to dangerous lows in the night. Lows are more dangerous overall then temp highs.

@elnjensen

Copy link
Copy Markdown
Contributor

@ksilive This change would have no effect on you if you don't enter future carbs. Simply accept the current time stamp for any carb entry and there is no safety issue.

@ksilive

ksilive commented Feb 17, 2024

Copy link
Copy Markdown

Users will try and experiment with this and I state again that this can be seriously dangerous.

Related point I will make is this, this safety limit I’m annoyed with. This is set way to high at 3,7 / 67 and I run weekly into it. Would I suggest to change this, probably not. I understand children and novice users also use loop. As stated before lows can be very serious and deadly.

@scottf51

scottf51 commented Feb 17, 2024 via email

Copy link
Copy Markdown

marionbarker added a commit to loopandlearn/Loop that referenced this pull request Mar 28, 2024
Parallel to LoopKit PR LoopKit#2125: modify maxCarbEntryFutureTime to 4 hours
@marionbarker

Copy link
Copy Markdown
Contributor Author

Closing because I do not think this will be accepted.

@scottf51

scottf51 commented Sep 20, 2024 via email

Copy link
Copy Markdown

@marionbarker

Copy link
Copy Markdown
Contributor Author

close this. I don't think this will ever be accepted. Available with the customization select script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants