Skip to content

docs: fix typo in comment and grammar in error message - #1

Open
Avicennasis wants to merge 1 commit into
FinVolution:masterfrom
TypoScan3000:docs/fix-typos
Open

Avicennasis wants to merge 1 commit into
FinVolution:masterfrom
TypoScan3000:docs/fix-typos

Conversation

@Avicennasis

Copy link
Copy Markdown

Summary

Fix two small text issues across 2 files:

  • core/llms/options.go: "Function defitions to include in the request." -> "Function definitions ..." in the CallOptions.Functions comment
  • internal/logic/common/chat_common.go: the error returned for an unknown chat message role read "ChatMessageType: %s is not support"; it now reads "... is not supported". No test asserts on this string.

The struct field SingeLineTemperature and its JSON key singeLineTemperature (internal/model/input/codein/code.go, manifest/config/xcoder_code_generate_llm_params_conf.json, docs/development.md) look like a misspelling of "single". I left them alone on purpose, because renaming the JSON key would break existing config files. That decision is yours.

No functional changes: one comment and the text of one error message.

Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant