Skip to content

fix: use zone filter values in H3C zone filters; fix two text typos - #1

Open
Avicennasis wants to merge 1 commit into
FinVolution:mainfrom
TypoScan3000:docs/fix-typos
Open

Avicennasis wants to merge 1 commit into
FinVolution:mainfrom
TypoScan3000:docs/fix-typos

Conversation

@Avicennasis

Copy link
Copy Markdown

Summary

  • service/pkg/firewall/h3c_v1/h3c_v1.go: behaviour fix, please review as a logic change. The source-zone and destination-zone filters compared the policy's zone list against strings.Split(servicePort, ",") instead of the zone value the user entered. As a result, filtering H3C policies by zone matched nothing, and every rule was skipped. They now split srcZone / destZone, the same as the Fortinet driver (fortinet_v1.go, strings.Split(srcZone, ",") / strings.Split(destZone, ",")).
  • service/pkg/firewall/requests/request.go: the doc comment on RequestParams started with HTTPClient, copied from the struct above it. It now starts with RequestParams.
  • service/router/v1/view.go: error message "Params validated failed" -> "Params validation failed". Only the response text changes; error code 1004 is unchanged.

The h3c_v1.go change alters filter behaviour. The other two changes are text only.

The srcZone and destZone filters in the H3C driver split servicePort instead of the zone value, so filtering by zone never matched (the Fortinet driver already splits srcZone/destZone). Also fix the RequestParams doc comment and the 'Params validated failed' message.

Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant