Repository navigation
Return the token from setRememberToken without password - #929
Open
VolodymyrLinuxovich wants to merge 1 commit into
Open
VolodymyrLinuxovich wants to merge 1 commit into
VolodymyrLinuxovich wants to merge 1 commit into
Conversation
The 5 argument setRememberToken set the cookie but returned an empty string. It now returns the sealed token like the deprecated overload. The test now checks the returned value against the cookie. Closes ESAPI#928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #928.
setRememberToken(request, response, maxAge, domain, path)added the cookie but returnedrval, which was always"". It now returnscryptToken, same as the deprecated overload. On an IntegrityException it still returns null.I also extended
testSetRememberTokento check the returned token against the cookie value. The loop in that test stopped at the first cookie with the remember token name. That one is the expired cookie fromkillCookie(), so it now keeps the last match instead.The new assertions fail on develop and pass with the change. HTTPUtilitiesTest and AuthenticatorTest pass, 38 tests.