Repository navigation
Fix personal door recipe to use one base door - #520
Open
Nitjsefnie wants to merge 1 commit into
Open
Nitjsefnie wants to merge 1 commit into
Nitjsefnie wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Author
|
Heads-up: this branch lives in an organization-owned fork, and GitHub doesn't let maintainers push to those. If anything needs changing, just say so here and I'll make the change on this branch right away. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Personal (quartz) Door recipe now consumes one base quartz door instead of two, per item 31.22 of the todo list in #31.
Related Issues and Pull Requests
Refs #31 (item 31.22)
Changes
DimdoorsRecipeProvider.kt: the shared dimensional-door recipe builder now emits a two-symbolXOpattern for the quartz base door and keepsXOXfor oak, iron and gold.item_ag_dim_dimdoors_quartz_door.jsonwith the repository's datagen (:dimdoors-fabric:runData); its only change is the pattern line.Testing
consumed=2) and passes after (consumed=1).sh ./gradlew :dimdoors-fabric:runData), exit 0 — the committed recipe is generator output, not hand-edited.consumed=1 produced=1); the same assertion run against the unmodified base fails withconsumed=2(run), so the check actually detects the defect.Follow-ups / Known Limitations
Generated by GLM-5.3-Flash (brief, CI), GPT-6.1 Sol (implementation, testing), GPT-6 Astra (review)