Skip to content

Fix personal door recipe to use one base door - #520

Open
Nitjsefnie wants to merge 1 commit into
DimensionalDevelopment:1.21.1from
Nitjsefnie-OSC:fix/31-personal-door-recipe
Open

Nitjsefnie wants to merge 1 commit into
DimensionalDevelopment:1.21.1from
Nitjsefnie-OSC:fix/31-personal-door-recipe

Conversation

@Nitjsefnie

@Nitjsefnie Nitjsefnie commented Oct 22, 2026 •

Copy link
Copy Markdown

Summary

The Personal (quartz) Door recipe now consumes one base quartz door instead of two, per item 31.22 of the todo list in #31.

Related Issues and Pull Requests

Refs #31 (item 31.22)

Changes

  • DimdoorsRecipeProvider.kt: the shared dimensional-door recipe builder now emits a two-symbol XO pattern for the quartz base door and keeps XOX for oak, iron and gold.
  • Regenerated item_ag_dim_dimdoors_quartz_door.json with the repository's datagen (:dimdoors-fabric:runData); its only change is the pattern line.

Testing

  • A standalone JSON check asserts the recipe consumes exactly one base quartz door and yields one Personal Door: it failed before the change (consumed=2) and passes after (consumed=1).
  • Datagen ran once (sh ./gradlew :dimdoors-fabric:runData), exit 0 — the committed recipe is generator output, not hand-edited.
  • CI on JDK 21 (Gradle build + datagen + recipe assertion): green on this branch head (run, log names the exact head SHA and prints consumed=1 produced=1); the same assertion run against the unmodified base fails with consumed=2 (run), so the check actually detects the defect.

Follow-ups / Known Limitations

  • This is a crafting-balance change taken from the todo list; whether the Personal Door should cost one base door in-game is the maintainers' call. The pattern is currently a single row; a different shape (for example keeping the original row length) is easy to adjust if preferred.
  • The Chaos Door half of the same todo item is out of scope: no current Chaos Door registration exists to build a recipe for, so that part needs a maintainer decision.

Generated by GLM-5.3-Flash (brief, CI), GPT-6.1 Sol (implementation, testing), GPT-6 Astra (review)

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@Nitjsefnie

Copy link
Copy Markdown
Author

Heads-up: this branch lives in an organization-owned fork, and GitHub doesn't let maintainers push to those. If anything needs changing, just say so here and I'll make the change on this branch right away.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant