Repository navigation
fix: use 15 minute polling interval while SSE is connected - #119
Merged
Merged
Conversation
Contributor
Author
|
Hi @jonathannorris , could you approve the CI run and review this? It's a one-line fix: the SSE polling interval is |
JamieSinn
reviewed
Nov 4, 2026
Comment on lines
+113
to
+121
| @patch("devcycle_python_sdk.api.config_client.ConfigAPIClient.get_config") | ||
| def test_sse_polling_interval_is_15_minutes(self, mock_get_config): | ||
| mock_get_config.return_value = (self.test_config_json, self.test_etag, None) | ||
| config_manager = EnvironmentConfigManager( | ||
| self.sdk_key, self.test_options, self.test_local_bucketing | ||
| ) | ||
| self.assertEqual(config_manager._sse_polling_interval, 15 * 60 * 1000) | ||
| config_manager.close() | ||
|
|
The SSE polling interval was 1000 * 60 * 15 * 60 ms (about 10 days) instead of the intended 15 minutes, so a missed or stale SSE update was not corrected by polling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JamieSinn
force-pushed
the
fix/sse-polling-interval
branch
from
November 5, 2026 14:01
96d2188 to
d3487f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_sse_polling_intervalis1000 * 60 * 15 * 60ms (~10 days). It should be 15 minutes, matching the Java SDK. With the current value, a missed or stale SSE update is never corrected by polling.🤖 Generated with Claude Code