Skip to content

London | 26-ITP-Sep | Rhoda Ajiroba | Sprint 3 | Implement and Rewrite Tests - #1769

Closed
codebyra wants to merge 2 commits into
CodeYourFuture:mainfrom
codebyra:coursework/implement-and-rewrite-tests
Closed

codebyra wants to merge 2 commits into
CodeYourFuture:mainfrom
codebyra:coursework/implement-and-rewrite-tests

Conversation

@codebyra

@codebyra codebyra commented Nov 9, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1059

Changelist

Implemented three JavaScript functions: getAngleType, isProperFraction, and getCardValue. Added comprehensive tests using Node's built-in test runner and rewrote the same tests using Jest, covering normal cases, boundary cases, and invalid inputs. All individual tests pass.

@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: format-clock-edge-cases/timeConverter.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: format-clock-edge-cases/timeConverter.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@codebyra codebyra closed this Nov 9, 2026
@codebyra

codebyra commented Nov 9, 2026

Copy link
Copy Markdown
Author

i did a new one

@codebyra
codebyra deleted the coursework/implement-and-rewrite-tests branch November 9, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant