Repository navigation
Recurse only into plain objects in nano-form-sanitize deep mode - #20
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the plain part of F10. With
deep: true, only plain objects are recursed into. File, Blob, Map, Set, URL, Date and class instances are returned as they are, where before they were rebuilt as{}(a form with a file upload lost the file). The files in this package use CRLF line endings, kept as they were.Not changed, design decisions: array handling under
deepand the name "sanitize".Tests:
packages/nano-form-sanitize/src/index.test.ts, newdeep mode with non-plain objectsblock. 2 fail on main, all 26 pass here, tsc clean.