Repository navigation
Make storage methods destructurable and scope clear to the prefix - #17
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the plain parts of F7.
createStorage()methods are closures, soconst { get, has } = createStorage()works.clear()with a prefix now removes only keys with that prefix, in localStorage and in the memory fallback (before, memory mode wiped every namespace). Without a prefix the library cannot tell its keys from others, soclear()still clears the whole store and the README now says so. No ttl check bug found that is not the ttl 0 decision, so none changed.Not changed, design decisions: no key separator between prefix and key,
setreturning void,ttl: 0meaning no expiry, and the "quota management" claim in the README.Tests:
packages/nano-safe-storage/src/index.test.ts, newdestructuring and clearblock. 3 fail on main, all 14 pass here, tsc clean.