Repository navigation
Fix deep-merge-lite constructor keys and nested __proto__ - #15
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isPlainObjectnow checks the prototype instead of.constructor, so a source with an ownconstructorkey is merged instead of dropped and nested objects with one are cloned instead of shared with the source.__proto__is skipped at every level (merge and clone). The old skip ofconstructorandprototypekeys is gone: they are plain data on a plain object and writing them cannot reachObject.prototype, which a test checks.Not changed, a design decision:
mergestill reads a trailing object witharrayMergeorcustomMergeas options, so a data object with those keys as last argument is taken as options.Tests:
packages/deep-merge-lite/src/index.test.ts(newconstructor and __proto__ keysblock). Fails on main, passes here.