Skip to content

Add a word boundary to the solicitation price pattern - #12

Merged
arnelirobles merged 1 commit into
mainfrom
fix/solicitation-word-boundary
Nov 12, 2026
Merged

arnelirobles merged 1 commit into
mainfrom
fix/solicitation-word-boundary

Conversation

@arnelirobles

@arnelirobles arnelirobles commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Adds a word boundary to the currency words in the solicitation price pattern, so words ending in "rs" followed by a number ("errors 2", "hours 5") are no longer labelled as solicitation.

Same change as BaryoDev/.github#34, which has the test table.

Summary by CodeRabbit

  • Bug Fixes
    • Currency-code matching now requires a word boundary before USD, EUR, INR, and Rs, reducing unintended matches. Other currency symbols and offer-related phrases retain their existing matching behavior.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The solicitation scan now requires a word boundary before usd, eur, inr, and rs. Currency-symbol matching and the other offer-related phrases retain their existing rules.

Changes: Solicitation scan

Layer / File(s) Summary
Currency-code matching
.github/workflows/flag-solicitation.yml
The scan requires a word boundary before usd, eur, inr, and rs. Comments describe this rule and reiterate the exclusions for bare “quote” and “estimate.”

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to e1e23

The change narrows solicitation detection so that words ending in "rs" followed by a number are no longer flagged. No actionable merge risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: a word boundary is added to the solicitation price pattern. The raw summary confirms that the workflow scan now requires a word boundary before the usd, eur, inr, and …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: a word boundary is added to the solicitation price pattern. The raw summary confirms that the workflow scan now requires a word boundary before the usd, eur, inr, and rs currency codes. The PR objectives state the same purpose, which is to stop words ending in rs followed by a number from being flagged. The title is specific and matches the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 310171ca-c9c2-4960-8378-6699792aec93
Commits

Reviewing files that changed from the base of the PR and between a6e0e22 and e1e2356.

Files selected for processing: 1

  • .github/workflows/flag-solicitation.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@arnelirobles
arnelirobles merged commit 0f20b1a into main Nov 12, 2026
3 checks passed
@arnelirobles
arnelirobles deleted the fix/solicitation-word-boundary branch November 12, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant