From 2ed3aad529925815111cc6a3817ef98118d5476b Mon Sep 17 00:00:00 2001 From: hemtilva Date: Mon, 16 Nov 2026 03:47:12 +0530 Subject: [PATCH] Require the 0x prefix in mixed-case ETH addresses The EIP-55 checksum path stripped every "0x" occurrence with str.replace before checking for 40 hex digits, so eth_address() accepted checksum addresses with no prefix, a doubled prefix, or "0x" inserted anywhere in the string. Match the full 0x-prefixed address first and drop only the leading prefix. --- src/validators/crypto_addresses/eth_address.py | 6 +++--- tests/crypto_addresses/test_eth_address.py | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/validators/crypto_addresses/eth_address.py b/src/validators/crypto_addresses/eth_address.py index 1d259ad0..4d507aff 100644 --- a/src/validators/crypto_addresses/eth_address.py +++ b/src/validators/crypto_addresses/eth_address.py @@ -16,11 +16,11 @@ def _validate_eth_checksum_address(addr: str): """Validate ETH type checksum address.""" - addr = addr.replace("0x", "") - - if not re.fullmatch(r"[0-9a-fA-F]{40}", addr): + if not re.fullmatch(r"0x[0-9a-fA-F]{40}", addr): return False + addr = addr[2:] + addr_hash = keccak.new(addr.lower().encode("ascii")).digest().hex() # type: ignore for i in range(0, 40): diff --git a/tests/crypto_addresses/test_eth_address.py b/tests/crypto_addresses/test_eth_address.py index de2fd313..afcb29fa 100644 --- a/tests/crypto_addresses/test_eth_address.py +++ b/tests/crypto_addresses/test_eth_address.py @@ -39,6 +39,11 @@ def test_returns_true_on_valid_eth_address(value: str): "validators.eth", # non-hex characters (the checksum path used to accept these) "0x" + "*" * 40, + # checksum addresses without the 0x prefix or with extra 0x markers + "5AEDA56215b167893e80B4fE645BA6d5Bab767DE", + "0x0x5AEDA56215b167893e80B4fE645BA6d5Bab767DE", + "0x5AEDA56215b1670x893e80B4fE645BA6d5Bab767DE", + "0x5AEDA56215b167893e80B4fE645BA6d5Bab767DE0x", ], ) def test_returns_failed_validation_on_invalid_eth_address(value: str):