From 51b0d6e0f618503adda477ef676707cf7aad1af4 Mon Sep 17 00:00:00 2001 From: ianmcorvidae Date: Sat, 14 Nov 2026 18:03:47 -0700 Subject: [PATCH] ci: unblock PR builds broken by Codecov v4 uploader sunset Every PR build job since ~Sept has failed at 'Upload coverage to Codecov': the codecov-action v4 uploader was sunset by Codecov, and with fail_ci_if_error: true plus the default fail-fast matrix, one codecov failure marks the whole build red and cancels the remaining Python versions. Tests themselves pass (validate + lint + mypy + the full pytest suite all green on these PRs). - bump codecov/codecov-action v4 -> v5 (the documented migration; v5 uses the current uploader and the workflow already passes ${{ secrets.CODECOV_TOKEN }}) - set fail_ci_if_error: false so coverage upload is best-effort until the CODECOV_TOKEN secret is confirmed current -- a coverage-hosting outage must never gate merges again After this lands: rebase the open dependabot PRs (@dependabot rebase or they auto-rebase on master change) so they pick up the fixed workflow and go green. --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2d8c40389..d2f423251 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -65,14 +65,14 @@ jobs: - name: Run lint, type check, and tests in parallel run: make -j3 --output-sync=target ci - name: Upload coverage to Codecov - uses: codecov/codecov-action@v4 + uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} env_vars: OS, PYTHON files: ./coverage.xml flags: unittests name: codecov-umbrella - fail_ci_if_error: true + fail_ci_if_error: false verbose: true simradio_testing: