diff --git a/ldclient/testing/test_ldclient.py b/ldclient/testing/test_ldclient.py index 6ce5442a..ecac3e74 100644 --- a/ldclient/testing/test_ldclient.py +++ b/ldclient/testing/test_ldclient.py @@ -175,3 +175,29 @@ def test_store_data_set_ordering(): if prereq_index > item_index: all_keys = (f["key"] for f in flags_list) raise Exception("%s depends on %s, but %s was listed first; keys in order are [%s]" % (item["key"], prereq["key"], item["key"], ", ".join(all_keys))) + + +def test_store_data_set_ordering_treats_null_prerequisites_as_empty(): + data = { + FEATURES: { + "a": {"key": "a", "prerequisites": [{"key": "b"}]}, + "b": {"key": "b", "prerequisites": None}, + }, + SEGMENTS: {}, + } + + class NullPrerequisitesDataUpdateProcessor(DependencyOrderingDataUpdateProcessor): + def __init__(self, config, store, ready): + store.init(data) + ready.set() + + store = CapturingFeatureStore() + config = Config(sdk_key='SDK_KEY', send_events=False, feature_store=store, update_processor_class=NullPrerequisitesDataUpdateProcessor) + + # Initialize the store with a flag whose prerequisites are null. + with LDClient(config=config): + pass + + # The store receives every flag, and the prerequisite comes first. + assert store.received_data is not None + assert list(store.received_data[FEATURES].keys()) == ["b", "a"] diff --git a/ldclient/versioned_data_kind.py b/ldclient/versioned_data_kind.py index 3f4f91fc..51cd66c9 100644 --- a/ldclient/versioned_data_kind.py +++ b/ldclient/versioned_data_kind.py @@ -68,7 +68,8 @@ def get_dependency_keys(self) -> Optional[Callable[[dict], Iterable[str]]]: stream_api_path="/flags/", decoder=FeatureFlag, priority=1, - get_dependency_keys=lambda flag: (p.get('key') for p in flag.get('prerequisites', [])), + # A null prerequisites list is the same as an omitted list. + get_dependency_keys=lambda flag: (p.get('key') for p in (flag.get('prerequisites') or [])), ) SEGMENTS = VersionedDataKindWithOrdering(namespace="segments", request_api_path="/sdk/latest-segments", stream_api_path="/segments/", decoder=Segment, priority=0, get_dependency_keys=None)