Skip to content

Commit ebff260

Browse files
Allow the signer to skip outbound TLS verification.
Stock orchestrators serve self-signed certificates, and discovery fails against the system trust store. InsecureSkipVerify turns verification off for every outbound signer connection. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 1432123 commit ebff260

14 files changed

Lines changed: 159 additions & 25 deletions

‎configs/signer/config.example.toml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ Orchestrators = []
1818
# Any allowed internal / private hosts for discovery; see docs/signer.md
1919
DiscoveryGrants = []
2020

21+
# Stock orchestrators serve self-signed certificates. The signer verifies TLS
22+
# against the system trust store by default. Set true to skip verification on
23+
# every outbound connection (discovery, auth webhook, RPC, and Kafka TLS).
24+
# InsecureSkipVerify = true
25+
2126
# The signer requires an on-chain connection at startup.
2227
# The RPC URL is an exact-byte secret file (omit a trailing newline).
2328
RPCURLFile = "/run/secrets/livepeer-signer-rpc-url"

‎docs/http-api.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,8 @@ Kafka settings use `[Kafka]` in TOML, `--kafka-*` flags, and
260260
`LIVEPEER_SIGNER_KAFKA_*` environment variables. Supplying any setting enables
261261
accounting and requires `Broker` and `Topic`. A broker accepts one `host[:port]`
262262
(bracket IPv6), with TLS/system trust by default; `kafkas://` selects TLS and
263-
`kafka://` selects plaintext. Credentials, paths, queries, and fragments are
263+
`kafka://` selects plaintext. `InsecureSkipVerify` also skips Kafka TLS
264+
verification. Credentials, paths, queries, and fragments are
264265
rejected. Advertised cluster brokers must support the same transport and auth.
265266

266267
Paired username/password secrets enable SASL; use files or

‎docs/signer.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,13 @@ The signer queries each configured orchestrator's `/discovery` endpoint when
9191
a client calls `GET /discover-orchestrators`. These configured URLs are its
9292
discovery sources; it does not automatically build a list from the chain.
9393

94+
Outbound HTTPS uses system certificate trust. Stock orchestrators often serve
95+
self-signed certificates. `InsecureSkipVerify` (flag `--insecure-skip-verify`,
96+
environment `LIVEPEER_SIGNER_INSECURE_SKIP_VERIFY`) turns verification off for
97+
every outbound signer connection: discovery, the authorization webhook,
98+
Ethereum RPC, and Kafka TLS. Leave it off unless those endpoints cannot
99+
present a publicly trusted certificate.
100+
94101
Query the signer to find runners:
95102

96103
```sh

‎signer/app.go‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ type Params struct {
5555
KeystorePasswordFile string `basepath:"source" secretfor:"KeystorePassword" descr:"Owner-only file containing the exact keystore password bytes"`
5656
Orchestrators []boa.Text[*url.URL] `name:"orchestrators" optional:"true"`
5757
DiscoveryGrants []string `name:"discovery-grants" optional:"true" descr:"Private discovery host[:port] grants"`
58+
InsecureSkipVerify bool `name:"insecure-skip-verify" descr:"Skip TLS certificate verification for all outbound signer connections"`
5859
}
5960

6061
func (p Params) payerPolicy() (pm.PayerPolicy, error) {
@@ -149,8 +150,14 @@ func serve(parent context.Context, p Params) error {
149150
}
150151
service := newService(key)
151152
defer service.Close()
153+
service.insecureSkipVerify = p.InsecureSkipVerify
152154
service.payerPolicy, _ = p.payerPolicy()
153-
rpc, err := eth.NewRPC(p.RPCURL, nil)
155+
var rpcTransport http.RoundTripper
156+
if p.InsecureSkipVerify {
157+
slog.Warn("signer TLS certificate verification is disabled for all outbound connections")
158+
rpcTransport = outboundHTTPTransport(true)
159+
}
160+
rpc, err := eth.NewRPC(p.RPCURL, rpcTransport)
154161
if err != nil {
155162
return fmt.Errorf("configure signer RPC (LIVEPEER_SIGNER_RPC_URL or --rpc-url-file): %w", err)
156163
}
@@ -187,7 +194,7 @@ func serve(parent context.Context, p Params) error {
187194
if err := service.SetDiscovery(p.discoveryURLs(), p.DiscoveryGrants...); err != nil {
188195
return err
189196
}
190-
producer, err := openKafkaProducer(ctx, p.Kafka, key.Address().Hex())
197+
producer, err := openKafkaProducer(ctx, p.Kafka, key.Address().Hex(), p.InsecureSkipVerify)
191198
if err != nil {
192199
return err
193200
}

‎signer/app_test.go‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ DiscoveryGrants = ["localhost:8935"]
155155
require.Equal(t, time.Hour, p.ETHUSDMaxAge)
156156
require.Equal(t, "http://localhost:8935", p.Orchestrators[0].Value.String())
157157
require.Equal(t, []string{"localhost:8935"}, p.DiscoveryGrants)
158+
require.False(t, p.InsecureSkipVerify)
158159
require.NoError(t, p.Validate())
159160
})
160161
}
@@ -179,6 +180,34 @@ func loadSignerParams(t *testing.T, args []string, config string) (Params, error
179180
return p, err
180181
}
181182

183+
func TestSignerInsecureSkipVerifyConfiguration(t *testing.T) {
184+
for _, test := range []struct {
185+
name string
186+
args []string
187+
env string
188+
config string
189+
want bool
190+
}{
191+
{name: "omitted"},
192+
{name: "CLI", args: []string{"--insecure-skip-verify"}, want: true},
193+
{name: "environment", env: "true", want: true},
194+
{name: "TOML", config: "InsecureSkipVerify = true\n", want: true},
195+
} {
196+
t.Run(test.name, func(t *testing.T) {
197+
t.Setenv("LIVEPEER_SIGNER_INSECURE_SKIP_VERIFY", test.env)
198+
p, err := loadSignerParams(t, test.args, test.config)
199+
require.NoError(t, err)
200+
require.Equal(t, test.want, p.InsecureSkipVerify)
201+
})
202+
}
203+
var help strings.Builder
204+
root := Root(&help, &help)
205+
root.SetArgs([]string{"--help"})
206+
require.NoError(t, root.Execute())
207+
require.Contains(t, help.String(), "--insecure-skip-verify")
208+
require.Contains(t, help.String(), "LIVEPEER_SIGNER_INSECURE_SKIP_VERIFY")
209+
}
210+
182211
func TestSignerDiscoveryGrantConfiguration(t *testing.T) {
183212
for _, test := range []struct {
184213
name string

‎signer/auth.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func (s *Service) SetAuthWebhook(endpoint *url.URL, headers Headers) error {
4040
if _, err := headers.MarshalText(); err != nil {
4141
return err
4242
}
43-
s.authClient = &http.Client{Transport: http.DefaultTransport.(*http.Transport).Clone(), Timeout: 5 * time.Second}
43+
s.authClient = &http.Client{Transport: outboundHTTPTransport(s.insecureSkipVerify), Timeout: 5 * time.Second}
4444
// Authentication is one explicit call, including when a target redirects.
4545
s.authClient.CheckRedirect = func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }
4646
s.authURL, s.authHeaders = endpoint.Clone(), Headers(http.Header(headers).Clone())

‎signer/discovery_test.go‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,3 +139,21 @@ func TestSignerDiscoveryReplacement(t *testing.T) {
139139
require.Empty(t, s.discoveryURLs)
140140
require.True(t, tracker.closed)
141141
}
142+
143+
func TestSignerDiscoveryInsecureSkipVerify(t *testing.T) {
144+
server := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
145+
_, _ = io.WriteString(w, `[{"address":"https://orch.example","runners":[{"url":"https://orch.example/app","app":"example","mode":"single-shot","capacity":1,"price_info":{"price":1,"currency":"wei","unit":"fixed"}}]}]`)
146+
}))
147+
defer server.Close()
148+
endpoint := testURL(t, server.URL)
149+
s := newService(nil)
150+
defer s.Close()
151+
require.NoError(t, s.SetDiscovery([]*url.URL{endpoint}, server.URL))
152+
require.Equal(t, 503, discoveryResponse(s, "").Code)
153+
s.insecureSkipVerify = true
154+
require.NoError(t, s.SetDiscovery([]*url.URL{endpoint}, server.URL))
155+
require.Equal(t, 200, discoveryResponse(s, "").Code)
156+
transport, ok := s.discoveryClient.Transport.(*http.Transport)
157+
require.True(t, ok)
158+
require.True(t, transport.TLSClientConfig.InsecureSkipVerify)
159+
}

‎signer/kafka.go‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func (c KafkaConfig) transport() (*kafka.Transport, error) {
169169
return transport, nil
170170
}
171171

172-
func openKafkaProducer(ctx context.Context, c *KafkaConfig, signer string) (*kafkaProducer, error) {
172+
func openKafkaProducer(ctx context.Context, c *KafkaConfig, signer string, insecureSkipVerify bool) (*kafkaProducer, error) {
173173
if c == nil {
174174
return nil, nil
175175
}
@@ -184,6 +184,9 @@ func openKafkaProducer(ctx context.Context, c *KafkaConfig, signer string) (*kaf
184184
if err != nil {
185185
return nil, err
186186
}
187+
if insecureSkipVerify && transport.TLS != nil {
188+
transport.TLS = insecureTLSConfig(transport.TLS)
189+
}
187190
outbox, err := openEventOutbox(ctx, c.OutboxDB, outboxBinding{Signer: signer, Broker: address, Topic: c.Topic}, c.OutboxMaxBytes)
188191
if err != nil {
189192
return nil, fmt.Errorf("open Kafka outbox %q (--kafka-outbox-db or LIVEPEER_SIGNER_KAFKA_OUTBOX_DB): %w", c.OutboxDB, err)

‎signer/kafka_config_test.go‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,13 @@ func TestKafkaConfigurationValidation(t *testing.T) {
5959
}
6060
require.Equal(t, strings.ToUpper(want), secureTransport.SASL.Name())
6161
}
62+
skippedCfg := valid
63+
skippedCfg.OutboxDB = filepath.Join(t.TempDir(), "events.sqlite")
64+
skipped, err := openKafkaProducer(t.Context(), &skippedCfg, "payer", true)
65+
require.NoError(t, err)
66+
t.Cleanup(func() { require.NoError(t, skipped.Close()) })
67+
require.True(t, skipped.transport.TLS.InsecureSkipVerify)
68+
require.Equal(t, uint16(tls.VersionTLS12), skipped.transport.TLS.MinVersion)
6269
valid.Username = "invalid\x07username"
6370
_, err = valid.transport()
6471
require.EqualError(t, err, "invalid Kafka SCRAM credentials; check LIVEPEER_SIGNER_KAFKA_USERNAME or --kafka-username-file and LIVEPEER_SIGNER_KAFKA_PASSWORD or --kafka-password-file")
@@ -170,7 +177,7 @@ func TestOptionalKafkaBoaConfiguration(t *testing.T) {
170177
require.NoError(t, err)
171178
if test.name == "omitted" || test.name == "config without Kafka" {
172179
require.Nil(t, p.Kafka)
173-
producer, err := openKafkaProducer(t.Context(), p.Kafka, "payer")
180+
producer, err := openKafkaProducer(t.Context(), p.Kafka, "payer", false)
174181
require.NoError(t, err)
175182
require.Nil(t, producer)
176183
return
@@ -179,7 +186,7 @@ func TestOptionalKafkaBoaConfiguration(t *testing.T) {
179186
require.Equal(t, filepath.Join(p.DataDir, "events.sqlite"), p.Kafka.OutboxDB)
180187
require.Equal(t, int64(268435456), p.Kafka.OutboxMaxBytes)
181188
require.Equal(t, "scram-sha-512", p.Kafka.AuthMethod)
182-
producer, err := openKafkaProducer(t.Context(), p.Kafka, "payer")
189+
producer, err := openKafkaProducer(t.Context(), p.Kafka, "payer", false)
183190
require.NoError(t, err)
184191
t.Cleanup(func() { require.NoError(t, producer.Close()) })
185192
info, err := os.Stat(p.Kafka.OutboxDB)

‎signer/kafka_integration_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func TestRealKafkaDeliveryAndRestartReplay(t *testing.T) {
6565
proxyAddress, roots = tlsKafkaProxy(t, broker.Addr())
6666
}
6767
open := func() *kafkaProducer {
68-
p, err := openKafkaProducer(t.Context(), &config, "payer")
68+
p, err := openKafkaProducer(t.Context(), &config, "payer", false)
6969
require.NoError(t, err)
7070
if test.tls {
7171
p.transport.TLS.RootCAs = roots
@@ -187,7 +187,7 @@ func TestKafkaUnresponsiveBrokerShutdownRetainsOutbox(t *testing.T) {
187187
accepted <- connection
188188
}
189189
}()
190-
p, err := openKafkaProducer(t.Context(), &KafkaConfig{Broker: kafkaBrokerURL(t, "kafka://"+listener.Addr().String()), Topic: "signing", OutboxDB: filepath.Join(t.TempDir(), "events.sqlite"), OutboxMaxBytes: 1 << 20}, "payer")
190+
p, err := openKafkaProducer(t.Context(), &KafkaConfig{Broker: kafkaBrokerURL(t, "kafka://"+listener.Addr().String()), Topic: "signing", OutboxDB: filepath.Join(t.TempDir(), "events.sqlite"), OutboxMaxBytes: 1 << 20}, "payer", false)
191191
require.NoError(t, err)
192192
require.NoError(t, p.Enqueue(t.Context(), testEvent()))
193193
ctx, cancel := context.WithCancel(t.Context())

0 commit comments

Comments
 (0)