From cba77286067b6b702f9bd5c32d5063c135e3d53f Mon Sep 17 00:00:00 2001 From: Nico Piel Date: Thu, 29 Oct 2026 16:40:43 +0100 Subject: [PATCH] Avoid pattern-matching instanceof in DestinationSet The Administrator parses userutil sources with javaparser 1.0.8 to build its code reference list. That parser only understands Java 5 syntax, so the "instanceof Set set" pattern match broke loading of the DestinationSet references on client startup. Fixes #533 Signed-off-by: Nico Piel --- .../com/mirth/connect/server/userutil/DestinationSet.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/src/main/java/com/mirth/connect/server/userutil/DestinationSet.java b/server/src/main/java/com/mirth/connect/server/userutil/DestinationSet.java index 76e1ff6e0..39abb862a 100644 --- a/server/src/main/java/com/mirth/connect/server/userutil/DestinationSet.java +++ b/server/src/main/java/com/mirth/connect/server/userutil/DestinationSet.java @@ -44,7 +44,9 @@ public DestinationSet(ImmutableConnectorMessage connectorMessage) { Set metaDataIds = null; try { - if (connectorMessage.getSourceMap().get(Constants.DESTINATION_SET_KEY) instanceof Set set) { + // No pattern matching here: the client's reference parser only understands Java 5 syntax + Object set = connectorMessage.getSourceMap().get(Constants.DESTINATION_SET_KEY); + if (set instanceof Set) { destinationIdMap = connectorMessage.getDestinationIdMap(); metaDataIds = (Set) set; }